[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14571 Thank you for merging, @hvanhovell ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14571 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64364/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14571 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14571 Merging to master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14571 **[Test build #64364 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64364/consoleFull)** for PR 14571 at commit [`64440c7`](https://github.com/apache/spark/commit/64440c773eab50877f16227a51d23e82a739d83e). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14571 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64355/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14571 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14571 **[Test build #64355 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64355/consoleFull)** for PR 14571 at commit [`5446a05`](https://github.com/apache/spark/commit/5446a057498af6ac371ea81db867754df99b031d). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14571 Thank you always, @hvanhovell ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14571 LGTM - pending jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14571 **[Test build #64364 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64364/consoleFull)** for PR 14571 at commit [`64440c7`](https://github.com/apache/spark/commit/64440c773eab50877f16227a51d23e82a739d83e). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14571 **[Test build #64355 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64355/consoleFull)** for PR 14571 at commit [`5446a05`](https://github.com/apache/spark/commit/5446a057498af6ac371ea81db867754df99b031d). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14571 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64130/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14571 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14571 **[Test build #64130 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64130/consoleFull)** for PR 14571 at commit [`27b419a`](https://github.com/apache/spark/commit/27b419ac61198bfe382e66c73d0500f78aabf280). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14571 **[Test build #64130 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64130/consoleFull)** for PR 14571 at commit [`27b419a`](https://github.com/apache/spark/commit/27b419ac61198bfe382e66c73d0500f78aabf280). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14571 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14571 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63987/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14571 **[Test build #63987 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63987/consoleFull)** for PR 14571 at commit [`3184424`](https://github.com/apache/spark/commit/31844240f0964c721a794d43cfb07d4b8609e222). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14571 Hi, @rxin . Could you review this PR again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14571 **[Test build #63987 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63987/consoleFull)** for PR 14571 at commit [`3184424`](https://github.com/apache/spark/commit/31844240f0964c721a794d43cfb07d4b8609e222). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14571 Hi, @rxin . After splitting window functions PR, is there any thing to do more for this `prettyName` PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14571 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63758/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14571 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14571 **[Test build #63758 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63758/consoleFull)** for PR 14571 at commit [`5f298e5`](https://github.com/apache/spark/commit/5f298e5bb0eeed1eeaaced58426daf848ef885ef). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14571 **[Test build #63758 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63758/consoleFull)** for PR 14571 at commit [`5f298e5`](https://github.com/apache/spark/commit/5f298e5bb0eeed1eeaaced58426daf848ef885ef). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14571 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63701/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14571 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14571 **[Test build #63701 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63701/consoleFull)** for PR 14571 at commit [`6ece3b1`](https://github.com/apache/spark/commit/6ece3b16570f817ca34095bf6fcc31ac36da58a5). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14571 **[Test build #63701 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63701/consoleFull)** for PR 14571 at commit [`6ece3b1`](https://github.com/apache/spark/commit/6ece3b16570f817ca34095bf6fcc31ac36da58a5). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14571 I felt that we need more decision points to improve `window_function.sql`. So, I made another jira and PR for that, https://github.com/apache/spark/pull/14623 for [SPARK-17044](https://issues.apache.org/jira/browse/SPARK-17044) . I will improve window function test there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14571 Hi, @gatorsmile . Thank you for review! BTW, I'm worrying if we are trying to keep two different things into one PR. I had better make a new Jira issue for the @rxin 's request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14571 https://github.com/petermaxlee/spark/blob/76defceb9fbaf13ca522da750d92eeb5f7799472/sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala#L227 Instead of creating a table in this .sql file, you can load it. Then, the other test cases can share it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14571 In that case, I'm wondering if we are able to delete `WindowQuerySuite.scala` safely here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14571 If `window_function.sql` is the only one left or you want to do that gradually, I will include that here today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14571 We can probably start with that one and then expand it if necessary. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14571 **[Test build #63660 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63660/consoleFull)** for PR 14571 at commit [`14339ae`](https://github.com/apache/spark/commit/14339ae811bc016ed949641b66cf12c45288a496). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14571 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14571 Hi, @rxin . The target suite will be `WindowQuerySuite`, I'll move all and remove that testsuite. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14571 **[Test build #63660 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63660/consoleFull)** for PR 14571 at commit [`14339ae`](https://github.com/apache/spark/commit/14339ae811bc016ed949641b66cf12c45288a496). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14571 THanks - it's a great 1st step to move the test case. That said, do you think you can simplify the test data? It is currently very verbose. It'd be better if it is something much simpler and easier to tell if the result is the correct one or not. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14571 Hi, @rxin . I added test files for window functions for SQLQueryTestSuite and removed the old `WindowQuerySuite.scala`. Could you review this again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14571 I see. Then, I'll include only that today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14571 Oh, I think you are working on that transition somewhere else. BTW, what about other tests? If you have a plan to enrich SQLQueryTestSuite, I prefer to do all of them in a single PR during this weekend. How do you think about making a single JIRA for that transition? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14571 Do you think you can create a test file for window functions in the new SQLQueryTestSuite along with this fix? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14571 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63628/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14571 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14571 **[Test build #63628 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63628/consoleFull)** for PR 14571 at commit [`7533000`](https://github.com/apache/spark/commit/7533000d3d0ede97ec4cad6c7cb5f733ff3dce7f). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14571 **[Test build #63628 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63628/consoleFull)** for PR 14571 at commit [`7533000`](https://github.com/apache/spark/commit/7533000d3d0ede97ec4cad6c7cb5f733ff3dce7f). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14571 Hi, @rxin . It's ready for review again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14571 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63502/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14571 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14571 **[Test build #63502 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63502/consoleFull)** for PR 14571 at commit [`0858a13`](https://github.com/apache/spark/commit/0858a132801040b0372cc1a59b0156299b152717). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14571 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63499/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14571 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14571 **[Test build #63499 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63499/consoleFull)** for PR 14571 at commit [`aadb419`](https://github.com/apache/spark/commit/aadb4193440b6bee4d95871d5bbbd06d4603e1d6). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14571 Finally, * Add `prettyName` and remove `sql` for `row_number` and `cume_dist`. * Add `prettyName` for `dense_rank` and `percent_rank`. * `LogicalPlanToSQLSuite` does not changed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14571 **[Test build #63502 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63502/consoleFull)** for PR 14571 at commit [`0858a13`](https://github.com/apache/spark/commit/0858a132801040b0372cc1a59b0156299b152717). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14571
Hm, interesting. Sorry, @rxin. I missed that the window functions need to
hide their children. The default behavior should be overrided. I'll revert the
last commit. Please refer the following.
```
[-DENSE_RANK()-]{+dense_rank(`gen_attr_0`, `gen_attr_1`)+}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14571 Oh, @rxin . It will break `LogicalPlanToSQLSuite` since the upper case function names like `ROW_NUMBER` is changed into `row_number`. I need to update `LogicalPlanToSQLSuite`, too. I will update them, too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14571 **[Test build #63499 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63499/consoleFull)** for PR 14571 at commit [`aadb419`](https://github.com/apache/spark/commit/aadb4193440b6bee4d95871d5bbbd06d4603e1d6). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14571 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14571 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63477/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14571 **[Test build #63477 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63477/consoleFull)** for PR 14571 at commit [`2c875dc`](https://github.com/apache/spark/commit/2c875dc3a6b761791651b6417631843bd360d91b). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14571: [SPARK-16983][SQL] Add `prettyName` for row_number, dens...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14571 **[Test build #63477 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63477/consoleFull)** for PR 14571 at commit [`2c875dc`](https://github.com/apache/spark/commit/2c875dc3a6b761791651b6417631843bd360d91b). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
