[GitHub] spark issue #14608: [SPARK-17013][SQL] Parse negative numeric literals
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14608 **[Test build #63644 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63644/consoleFull)** for PR 14608 at commit [`154abba`](https://github.com/apache/spark/commit/154abba4cff36f352e47927d8b707b1c3fa25668). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14608: [SPARK-17013][SQL] Parse negative numeric literals
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14608 adding a space LGTM. I think `UnaryMinus` is the only special case? Adding parentheses at the outside of each expression should work for all other cases. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14608: [SPARK-17013][SQL] Parse negative numeric literals
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14608 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14608: [SPARK-17013][SQL] Parse negative numeric literals
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14608 **[Test build #63634 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63634/consoleFull)** for PR 14608 at commit [`1ae7a3b`](https://github.com/apache/spark/commit/1ae7a3b9f63a9787304b74bc10914b436574eb78). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14608: [SPARK-17013][SQL] Parse negative numeric literals
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14608 Shouldn't we wrap literals with () to be safe? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14608: [SPARK-17013][SQL] Parse negative numeric literals
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14608 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63652/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14608: [SPARK-17013][SQL] Parse negative numeric literals
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14608 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14608: [SPARK-17013][SQL] Parse negative numeric literals
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14608 **[Test build #63652 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63652/consoleFull)** for PR 14608 at commit [`908253b`](https://github.com/apache/spark/commit/908253b92f87c823b7104f7b0df6f8ae6b4fd814). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14608: [SPARK-17013][SQL] Parse negative numeric literals
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14608 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63644/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14608: [SPARK-17013][SQL] Parse negative numeric literals
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14608 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14608: [SPARK-17013][SQL] Parse negative numeric literals
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14608 **[Test build #63644 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63644/consoleFull)** for PR 14608 at commit [`154abba`](https://github.com/apache/spark/commit/154abba4cff36f352e47927d8b707b1c3fa25668). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14608: [SPARK-17013][SQL] Parse negative numeric literals
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14608 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63634/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14608: [SPARK-17013][SQL] Parse negative numeric literals
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14608 **[Test build #63634 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63634/consoleFull)** for PR 14608 at commit [`1ae7a3b`](https://github.com/apache/spark/commit/1ae7a3b9f63a9787304b74bc10914b436574eb78). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
