[GitHub] spark issue #14891: [SQL][DOC][MINOR] Add (Scala-specific) and (Java-specifi...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14891 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14891: [SQL][DOC][MINOR] Add (Scala-specific) and (Java-specifi...
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/14891 @srowen, anyone you'd recommend to accept the PR (after you accepted)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14891: [SQL][DOC][MINOR] Add (Scala-specific) and (Java-specifi...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14891 OK fair enough LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14891: [SQL][DOC][MINOR] Add (Scala-specific) and (Java-specifi...
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/14891 Frankly, I'd not have bothered with the changes if I had not seen them elsewhere. See http://spark.apache.org/docs/latest/api/scala/index.html#org.apache.spark.sql.Dataset and look for `foreach` and `foreachPartition` for (Java-specific) while http://spark.apache.org/docs/latest/api/scala/index.html#org.apache.spark.sql.Encoders$ and `javaSerialization` / `kryo` for (Scala-specific). I have seen examples with both in one source like http://spark.apache.org/docs/latest/api/scala/index.html#org.apache.spark.sql.RelationalGroupedDataset. That was the main reason while the other was to understand why there are two different variants of the same method (and then it clicked but only when I'd seen the other examples). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14891: [SQL][DOC][MINOR] Add (Scala-specific) and (Java-specifi...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14891 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64708/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14891: [SQL][DOC][MINOR] Add (Scala-specific) and (Java-specifi...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14891 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14891: [SQL][DOC][MINOR] Add (Scala-specific) and (Java-specifi...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14891 **[Test build #64708 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64708/consoleFull)** for PR 14891 at commit [`a927c83`](https://github.com/apache/spark/commit/a927c83888e93742ab41db435df8db8f0065037e). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14891: [SQL][DOC][MINOR] Add (Scala-specific) and (Java-specifi...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14891 I think this kind of thing is fine to call out, but we haven't used this convention, quite, elsewhere. The APIs are all "Scala-specific" unless otherwise noted. Even then they're callable from Java, just not very conveniently. There are some methods that exist specifically to make calling from Java simpler. In other cases I've just seen this described with a sentence of prose that says this is a convenience method for Java callers. That might be more explanatory than just writing "Java-specific", because indeed even those are callable from Scala and aren't that specific to Java. I'd just note the methods that are Java-friendly, and borrow a sentence from existing doc of similar methods. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14891: [SQL][DOC][MINOR] Add (Scala-specific) and (Java-specifi...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14891 **[Test build #64708 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64708/consoleFull)** for PR 14891 at commit [`a927c83`](https://github.com/apache/spark/commit/a927c83888e93742ab41db435df8db8f0065037e). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
