[GitHub] spark issue #15017: [SPARK-17456][CORE] Utility for parsing Spark versions

2016-09-09 Thread jkbradley
Github user jkbradley commented on the issue:

https://github.com/apache/spark/pull/15017
  
OK I did the backport.  I checked out branch-2.0 and ran the test locally.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #15017: [SPARK-17456][CORE] Utility for parsing Spark versions

2016-09-09 Thread jkbradley
Github user jkbradley commented on the issue:

https://github.com/apache/spark/pull/15017
  
Actually, I'd like to backport this to 2.0 since I'd like to put 
[https://issues.apache.org/jira/browse/SPARK-16240] into 2.0 as well.  I'll do 
the backport.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #15017: [SPARK-17456][CORE] Utility for parsing Spark versions

2016-09-09 Thread jkbradley
Github user jkbradley commented on the issue:

https://github.com/apache/spark/pull/15017
  
Thanks @yanboliang !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #15017: [SPARK-17456][CORE] Utility for parsing Spark versions

2016-09-09 Thread yanboliang
Github user yanboliang commented on the issue:

https://github.com/apache/spark/pull/15017
  
We can replace the hacks by the new utility in 
[SPARK-17462](https://issues.apache.org/jira/browse/SPARK-17462). Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #15017: [SPARK-17456][CORE] Utility for parsing Spark versions

2016-09-09 Thread yanboliang
Github user yanboliang commented on the issue:

https://github.com/apache/spark/pull/15017
  
LGTM, merged into master. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #15017: [SPARK-17456][CORE] Utility for parsing Spark versions

2016-09-08 Thread holdenk
Github user holdenk commented on the issue:

https://github.com/apache/spark/pull/15017
  
Sounds good :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #15017: [SPARK-17456][CORE] Utility for parsing Spark versions

2016-09-08 Thread jkbradley
Github user jkbradley commented on the issue:

https://github.com/apache/spark/pull/15017
  
I like splitting things into separate PRs, but I'll go ahead and make a 
follow-up task to check for places which can be fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #15017: [SPARK-17456][CORE] Utility for parsing Spark versions

2016-09-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/15017
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #15017: [SPARK-17456][CORE] Utility for parsing Spark versions

2016-09-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/15017
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65115/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #15017: [SPARK-17456][CORE] Utility for parsing Spark versions

2016-09-08 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/15017
  
**[Test build #65115 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65115/consoleFull)**
 for PR 15017 at commit 
[`8978cb3`](https://github.com/apache/spark/commit/8978cb33f35b0b2a544c29eb19e8b740637e83d8).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #15017: [SPARK-17456][CORE] Utility for parsing Spark versions

2016-09-08 Thread holdenk
Github user holdenk commented on the issue:

https://github.com/apache/spark/pull/15017
  
Would it make sense to replace some of the hacks with this util at the same 
time?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #15017: [SPARK-17456][CORE] Utility for parsing Spark versions

2016-09-08 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/15017
  
**[Test build #65115 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65115/consoleFull)**
 for PR 15017 at commit 
[`8978cb3`](https://github.com/apache/spark/commit/8978cb33f35b0b2a544c29eb19e8b740637e83d8).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #15017: [SPARK-17456][CORE] Utility for parsing Spark versions

2016-09-08 Thread jkbradley
Github user jkbradley commented on the issue:

https://github.com/apache/spark/pull/15017
  
CC: @yanboliang @MLnick Does one of you have time to review this?  It 
should be very quick.  Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org