[GitHub] spark issue #15182: [SPARK-17625] [SQL] set expectedOutputAttributes when co...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/15182 thanks, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15182: [SPARK-17625] [SQL] set expectedOutputAttributes when co...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15182 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65756/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15182: [SPARK-17625] [SQL] set expectedOutputAttributes when co...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15182 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15182: [SPARK-17625] [SQL] set expectedOutputAttributes when co...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15182 **[Test build #65756 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65756/consoleFull)** for PR 15182 at commit [`e2c3b9d`](https://github.com/apache/spark/commit/e2c3b9df0431885efbc9575beb7735590a77cf2f). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15182: [SPARK-17625] [SQL] set expectedOutputAttributes when co...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/15182 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15182: [SPARK-17625] [SQL] set expectedOutputAttributes when co...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15182 LGTM pending Jenkins --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15182: [SPARK-17625] [SQL] set expectedOutputAttributes when co...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15182 **[Test build #65756 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65756/consoleFull)** for PR 15182 at commit [`e2c3b9d`](https://github.com/apache/spark/commit/e2c3b9df0431885efbc9575beb7735590a77cf2f). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15182: [SPARK-17625] [SQL] set expectedOutputAttributes when co...
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/15182 @cloud-fan Ok. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15182: [SPARK-17625] [SQL] set expectedOutputAttributes when co...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/15182 Let's put it in `DataFrameSuite` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15182: [SPARK-17625] [SQL] set expectedOutputAttributes when co...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15182 The fix looks ok to me, but you need to improve your PR description. It might not be easy for reviewers to understand your fix based on your PR description. I do not know which test suite is the best place, but `SQLQuerySuite` is not good for sure. Your test case is not related to SQL. Let @cloud-fan make the decision. : ) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15182: [SPARK-17625] [SQL] set expectedOutputAttributes when co...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15182 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65725/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15182: [SPARK-17625] [SQL] set expectedOutputAttributes when co...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15182 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15182: [SPARK-17625] [SQL] set expectedOutputAttributes when co...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15182 **[Test build #65725 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65725/consoleFull)** for PR 15182 at commit [`3e7beb8`](https://github.com/apache/spark/commit/3e7beb84555057c85582a19e804626871bd16016). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15182: [SPARK-17625] [SQL] set expectedOutputAttributes when co...
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/15182 May be the position of the test case is not right, where should I put it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15182: [SPARK-17625] [SQL] set expectedOutputAttributes when co...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15182 **[Test build #65725 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65725/consoleFull)** for PR 15182 at commit [`3e7beb8`](https://github.com/apache/spark/commit/3e7beb84555057c85582a19e804626871bd16016). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15182: [SPARK-17625] [SQL] set expectedOutputAttributes when co...
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/15182 @cloud-fan @gatorsmile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org