[GitHub] spark issue #15335: [SPARK-17769][Core][Scheduler]Some FetchFailure refactor...
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/15335 I read through the code and the discussion and things lgtm. Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15335: [SPARK-17769][Core][Scheduler]Some FetchFailure refactor...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15335 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70258/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15335: [SPARK-17769][Core][Scheduler]Some FetchFailure refactor...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15335 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15335: [SPARK-17769][Core][Scheduler]Some FetchFailure refactor...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15335 **[Test build #70258 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70258/testReport)** for PR 15335 at commit [`c80ad22`](https://github.com/apache/spark/commit/c80ad22a242255cac91cce2c7c537f9b21100f70). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15335: [SPARK-17769][Core][Scheduler]Some FetchFailure refactor...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15335 **[Test build #70258 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70258/testReport)** for PR 15335 at commit [`c80ad22`](https://github.com/apache/spark/commit/c80ad22a242255cac91cce2c7c537f9b21100f70). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15335: [SPARK-17769][Core][Scheduler]Some FetchFailure refactor...
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/15335 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15335: [SPARK-17769][Core][Scheduler]Some FetchFailure refactor...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15335 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15335: [SPARK-17769][Core][Scheduler]Some FetchFailure refactor...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15335 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70217/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15335: [SPARK-17769][Core][Scheduler]Some FetchFailure refactor...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15335 **[Test build #70217 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70217/testReport)** for PR 15335 at commit [`c80ad22`](https://github.com/apache/spark/commit/c80ad22a242255cac91cce2c7c537f9b21100f70). * This patch **fails PySpark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15335: [SPARK-17769][Core][Scheduler]Some FetchFailure refactor...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15335 **[Test build #70217 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70217/testReport)** for PR 15335 at commit [`c80ad22`](https://github.com/apache/spark/commit/c80ad22a242255cac91cce2c7c537f9b21100f70). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15335: [SPARK-17769][Core][Scheduler]Some FetchFailure refactor...
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/15335 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15335: [SPARK-17769][Core][Scheduler]Some FetchFailure refactor...
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/15335 ok, I'll rerun tests to make sure and take a look. retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15335: [SPARK-17769][Core][Scheduler]Some FetchFailure refactor...
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/15335 It's worth something, but not a lot. I think it's worth merging, but if someone thinks it's not, I'm not going to fight it. Read it and merge if you want to. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15335: [SPARK-17769][Core][Scheduler]Some FetchFailure refactor...
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/15335 I'm just asking because you guys discussed this and seemed to reach an agreement, but the PR is still open after a couple of months. I haven't actually read the code, but can do if you think it might add something. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15335: [SPARK-17769][Core][Scheduler]Some FetchFailure refactor...
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/15335 @vanzin It should be committed if you think it adds enough additional clarity that it is worth the penalty of making future backporting or other debugging maintenance a little more difficult. It doesn't change functionality much, so it's mostly just to increase the comprehensibility of the code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15335: [SPARK-17769][Core][Scheduler]Some FetchFailure refactor...
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/15335 so is this still good? should it be committed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15335: [SPARK-17769][Core][Scheduler]Some FetchFailure refactor...
Github user squito commented on the issue: https://github.com/apache/spark/pull/15335 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15335: [SPARK-17769][Core][Scheduler]Some FetchFailure refactor...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15335 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66272/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15335: [SPARK-17769][Core][Scheduler]Some FetchFailure refactor...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15335 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15335: [SPARK-17769][Core][Scheduler]Some FetchFailure refactor...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15335 **[Test build #66272 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66272/consoleFull)** for PR 15335 at commit [`daba878`](https://github.com/apache/spark/commit/daba8787cb3ed2ea8179225f28541f62de637238). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15335: [SPARK-17769][Core][Scheduler]Some FetchFailure refactor...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15335 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66273/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15335: [SPARK-17769][Core][Scheduler]Some FetchFailure refactor...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15335 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15335: [SPARK-17769][Core][Scheduler]Some FetchFailure refactor...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15335 **[Test build #66273 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66273/consoleFull)** for PR 15335 at commit [`c80ad22`](https://github.com/apache/spark/commit/c80ad22a242255cac91cce2c7c537f9b21100f70). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15335: [SPARK-17769][Core][Scheduler]Some FetchFailure refactor...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15335 **[Test build #66273 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66273/consoleFull)** for PR 15335 at commit [`c80ad22`](https://github.com/apache/spark/commit/c80ad22a242255cac91cce2c7c537f9b21100f70). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15335: [SPARK-17769][Core][Scheduler]Some FetchFailure refactor...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15335 **[Test build #66272 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66272/consoleFull)** for PR 15335 at commit [`daba878`](https://github.com/apache/spark/commit/daba8787cb3ed2ea8179225f28541f62de637238). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
