[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/15568 thanks for the review, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog
Github user ericl commented on the issue: https://github.com/apache/spark/pull/15568 lgtm, thanks for adding the test! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15568 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15568 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67444/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15568 **[Test build #67444 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67444/consoleFull)** for PR 15568 at commit [`c4a906f`](https://github.com/apache/spark/commit/c4a906f99836fab8e21ecd3215112e8b20f218a4). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15568 **[Test build #67444 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67444/consoleFull)** for PR 15568 at commit [`c4a906f`](https://github.com/apache/spark/commit/c4a906f99836fab8e21ecd3215112e8b20f218a4). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/15568 @mallman , item 4 is a potential problem in the future. The current workflow is, we get the `MetastoreRelation` via `HiveMetastoreCatalog.lookupRelation`, which always lower case the database and table name. Then we construct `TableFileCatalog` and call `ExternalCatalog.listPartitionsByFilter` with the database and table name. So we won't have case senstivity problem here. However, we may have a workflow which call `listPartitionsByFilter` directly with database and table name given by users. e.g. #15302. Then we need to care about case sensitivity. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog
Github user ericl commented on the issue: https://github.com/apache/spark/pull/15568 LGTM, but had a question on why we need to override equals(). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog
Github user mallman commented on the issue: https://github.com/apache/spark/pull/15568 @cloud-fan, I don't know what you mean in item 4 about `SessionCatalog.listPartitionsByFilter` handling case-sensitivity. What case-sensitivity issue are you referring to, and does this PR handle it differently? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15568 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15568 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67266/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15568 **[Test build #67266 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67266/consoleFull)** for PR 15568 at commit [`c98c4f6`](https://github.com/apache/spark/commit/c98c4f6e53cc3acfd9602d23badd6e4677afa00f). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15568 **[Test build #67266 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67266/consoleFull)** for PR 15568 at commit [`c98c4f6`](https://github.com/apache/spark/commit/c98c4f6e53cc3acfd9602d23badd6e4677afa00f). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15568 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67265/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15568 **[Test build #67265 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67265/consoleFull)** for PR 15568 at commit [`bd808af`](https://github.com/apache/spark/commit/bd808afd6fceeca6844e35de24a8efbfdae430ba). * This patch **fails to build**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15568 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/15568 cc @ericl @mallman @yhuai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15568 **[Test build #67265 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67265/consoleFull)** for PR 15568 at commit [`bd808af`](https://github.com/apache/spark/commit/bd808afd6fceeca6844e35de24a8efbfdae430ba). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
