[GitHub] spark issue #15715: [SPARK-18198][Doc][Streaming] Highlight code snippets
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15715 Oops, I see, we've cut branch 2.1. I must have missed that one too along with other dev@ lists going to spam. Yes I will go back and make sure a few I've just merged to master are in 2.1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15715: [SPARK-18198][Doc][Streaming] Highlight code snippets
Github user lw-lin commented on the issue: https://github.com/apache/spark/pull/15715 @srowen thanks -- could we also merge this into branch-2.1? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15715: [SPARK-18198][Doc][Streaming] Highlight code snippets
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15715 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15715: [SPARK-18198][Doc][Streaming] Highlight code snippets
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15715 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15715: [SPARK-18198][Doc][Streaming] Highlight code snippets
Github user koeninger commented on the issue: https://github.com/apache/spark/pull/15715 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15715: [SPARK-18198][Doc][Streaming] Highlight code snippets
Github user lw-lin commented on the issue: https://github.com/apache/spark/pull/15715 Sounds good! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15715: [SPARK-18198][Doc][Streaming] Highlight code snippets
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15715 I guess we could restructure the headings to not have these numbered, indented sections to begin with, but that's a separate task I think. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15715: [SPARK-18198][Doc][Streaming] Highlight code snippets
Github user lw-lin commented on the issue: https://github.com/apache/spark/pull/15715 Good question! Actually I had tried keeping the indent of the div tags but un-indenting only the code before I open this pr -- and it looked like this:  That was when I gave up trying more on the `flume`, `kinesis`, `kafka08` docs. :-D --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15715: [SPARK-18198][Doc][Streaming] Highlight code snippets
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15715 What about keeping the indent of the div tags but un-indenting only the code? it might look weird in markdown but does it look nice in the rendered output? If it's any more trouble than that, forget it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15715: [SPARK-18198][Doc][Streaming] Highlight code snippets
Github user lw-lin commented on the issue: https://github.com/apache/spark/pull/15715  Please see the screenshot above -- this is `flume doc` -- I got this by unindenting the second block. Then: - the second block's indent does not look as pretty as the first's and the third's - the third block's numbering just goes wrong -- it should have been `3.` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15715: [SPARK-18198][Doc][Streaming] Highlight code snippets
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15715 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67899/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15715: [SPARK-18198][Doc][Streaming] Highlight code snippets
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15715 What about unindenting those blocks? I don't see why they have to be in the first place. They're HTML tags. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15715: [SPARK-18198][Doc][Streaming] Highlight code snippets
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15715 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15715: [SPARK-18198][Doc][Streaming] Highlight code snippets
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15715 **[Test build #67899 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67899/consoleFull)** for PR 15715 at commit [`5f2c21b`](https://github.com/apache/spark/commit/5f2c21bda38d44a2a1cad118aa470f4baec8f95d). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15715: [SPARK-18198][Doc][Streaming] Highlight code snippets
Github user lw-lin commented on the issue:
https://github.com/apache/spark/pull/15715
@srowen thanks.
I'm afraid the streaming `flume integration doc`, `kinesis integration
doc`, as well as `kafka08 integration doc` also need code highlights, but this
`{% hightlight %}` syntax seem to be conflict with the indentation syntax (e.g.
https://github.com/apache/spark/blame/branch-2.0/docs/streaming-flume-integration.md#L40-L73).
So that's why the `flume`, `kinesis`, `kafka08` docs don't have code
highlights in the first place. `structured streaming kafka010`, `spark
streaming kafka010`doc, on the other hand, don't have such conflicts -- so
we're adding code highlights here.
And to my acknowledgement, no other code base need this treatment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15715: [SPARK-18198][Doc][Streaming] Highlight code snippets
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15715 That is nicer. Are there any other code snippets across the code base that need this treatment? seems like this is always the right thing to do. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15715: [SPARK-18198][Doc][Streaming] Highlight code snippets
Github user lw-lin commented on the issue: https://github.com/apache/spark/pull/15715 @koeninger @srowen it'd be great if you could take a look at this too :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15715: [SPARK-18198][Doc][Streaming] Highlight code snippets
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15715 **[Test build #67899 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67899/consoleFull)** for PR 15715 at commit [`5f2c21b`](https://github.com/apache/spark/commit/5f2c21bda38d44a2a1cad118aa470f4baec8f95d). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15715: [SPARK-18198][Doc][Streaming] Highlight code snippets
Github user lw-lin commented on the issue: https://github.com/apache/spark/pull/15715 Fix the leading spaces is needed, because without the fixing the code snippet would contain leading spaces as well(see the pic below), which is quite inconsistent with the other programming guides.  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
