[GitHub] spark issue #15790: [SPARK-18264][SPARKR] build vignettes with package, upda...
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/15790 Sure - Sounds good. LGTM. Merging this to master and branch-2.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15790: [SPARK-18264][SPARKR] build vignettes with package, upda...
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/15790 Problem is the required and generated `vignette.rds` RDS file is a binary file? I'm not sure about checking in binaries in git, that would show up in a source-only release? Maybe create-distribution.sh should run the equivalent of `R CMD install SparkR.tar.gz` to generate the binaries necessary that would only go to a binary release? How about we merge this PR first - I can test out the release mechanism more next week. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15790: [SPARK-18264][SPARKR] build vignettes with package, upda...
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/15790 So one proposal I was thinking of is to just check in a built version of the vignette in to the source tree. That way the release packaging wouldn't need to change. The only thing to keep in mind is that whenever we update the vignette we will need to rebuild it. Thoughts ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15790: [SPARK-18264][SPARKR] build vignettes with package, upda...
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/15790 I think https://github.com/apache/spark/blob/master/dev/make-distribution.sh should change too but I'm not 100% how the R package is built there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15790: [SPARK-18264][SPARKR] build vignettes with package, upda...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15790 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68500/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15790: [SPARK-18264][SPARKR] build vignettes with package, upda...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15790 **[Test build #68500 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68500/consoleFull)** for PR 15790 at commit [`1681005`](https://github.com/apache/spark/commit/1681005b6fe237d931fcea3daeaed3cb8c6087a1). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15790: [SPARK-18264][SPARKR] build vignettes with package, upda...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15790 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15790: [SPARK-18264][SPARKR] build vignettes with package, upda...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15790 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68498/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15790: [SPARK-18264][SPARKR] build vignettes with package, upda...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15790 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15790: [SPARK-18264][SPARKR] build vignettes with package, upda...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15790 **[Test build #68498 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68498/consoleFull)** for PR 15790 at commit [`4d34bbe`](https://github.com/apache/spark/commit/4d34bbee5ab92a3bd796de3d07a71e8726b0caa3). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15790: [SPARK-18264][SPARKR] build vignettes with package, upda...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15790 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15790: [SPARK-18264][SPARKR] build vignettes with package, upda...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15790 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68497/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15790: [SPARK-18264][SPARKR] build vignettes with package, upda...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15790 **[Test build #68497 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68497/consoleFull)** for PR 15790 at commit [`323609e`](https://github.com/apache/spark/commit/323609e43ab11ce4e5f62a13942b3c0cc3cbc85f). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15790: [SPARK-18264][SPARKR] build vignettes with package, upda...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15790 **[Test build #68500 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68500/consoleFull)** for PR 15790 at commit [`1681005`](https://github.com/apache/spark/commit/1681005b6fe237d931fcea3daeaed3cb8c6087a1). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15790: [SPARK-18264][SPARKR] build vignettes with package, upda...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15790 **[Test build #68498 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68498/consoleFull)** for PR 15790 at commit [`4d34bbe`](https://github.com/apache/spark/commit/4d34bbee5ab92a3bd796de3d07a71e8726b0caa3). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15790: [SPARK-18264][SPARKR] build vignettes with package, upda...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15790 **[Test build #68497 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68497/consoleFull)** for PR 15790 at commit [`323609e`](https://github.com/apache/spark/commit/323609e43ab11ce4e5f62a13942b3c0cc3cbc85f). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15790: [SPARK-18264][SPARKR] build vignettes with package, upda...
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/15790
Tested that more, I think the vignettes works only with installed package
(or installed built package)
```
R CMD INSTALL SparkR_2.1.0.tar.gz
```
and then
```
library(SparkR)
vignette("sparkr-vignettes", package="SparkR")
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15790: [SPARK-18264][SPARKR] build vignettes with package, upda...
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/15790
@felixcheung I noticed one more thing - We are somehow not registering the
vignette correctly with the R package. So for example if I launch
`./bin/sparkR` and then run `vignette(package="dplyr")`
I see a list of vignettes that I can then launch with
`vignette("introduction", package="dplyr")`. However this doesn't seem to work
with our vignette - I'm not sure what we need to do to get this to work though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15790: [SPARK-18264][SPARKR] build vignettes with package, upda...
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/15790 Sorry I got caught up with some other stuff - Will take a look at this today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15790: [SPARK-18264][SPARKR] build vignettes with package, upda...
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/15790 ping @shivaram --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15790: [SPARK-18264][SPARKR] build vignettes with package, upda...
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/15790 this is good to go in? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15790: [SPARK-18264][SPARKR] build vignettes with package, upda...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15790 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68352/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15790: [SPARK-18264][SPARKR] build vignettes with package, upda...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15790 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15790: [SPARK-18264][SPARKR] build vignettes with package, upda...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15790 **[Test build #68352 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68352/consoleFull)** for PR 15790 at commit [`9f24e3f`](https://github.com/apache/spark/commit/9f24e3f89595d469d279093a924d13898de0517d). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15790: [SPARK-18264][SPARKR] build vignettes with package, upda...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15790 **[Test build #68352 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68352/consoleFull)** for PR 15790 at commit [`9f24e3f`](https://github.com/apache/spark/commit/9f24e3f89595d469d279093a924d13898de0517d). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15790: [SPARK-18264][SPARKR] build vignettes with package, upda...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15790 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68348/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15790: [SPARK-18264][SPARKR] build vignettes with package, upda...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15790 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15790: [SPARK-18264][SPARKR] build vignettes with package, upda...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15790 **[Test build #68348 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68348/consoleFull)** for PR 15790 at commit [`4d6c919`](https://github.com/apache/spark/commit/4d6c919b8517cb30430677cfd5efa64da873a234). * This patch **fails SparkR unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15790: [SPARK-18264][SPARKR] build vignettes with package, upda...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15790 **[Test build #68348 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68348/consoleFull)** for PR 15790 at commit [`4d6c919`](https://github.com/apache/spark/commit/4d6c919b8517cb30430677cfd5efa64da873a234). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15790: [SPARK-18264][SPARKR] build vignettes with package, upda...
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/15790 ok, qpdf is installed per the jira. no environment variables set up yet though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15790: [SPARK-18264][SPARKR] build vignettes with package, upda...
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/15790 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
