[GitHub] spark issue #15857: [SPARK-18300][SQL] Do not apply foldable propagation wit...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15857 Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15857: [SPARK-18300][SQL] Do not apply foldable propagation wit...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15857 I am working on a fix for 2.10. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15857: [SPARK-18300][SQL] Do not apply foldable propagation wit...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15857 I am going to revert this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15857: [SPARK-18300][SQL] Do not apply foldable propagation wit...
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/15857 Seems this breaks the scala 2.10 build? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15857: [SPARK-18300][SQL] Do not apply foldable propagation wit...
Github user yhuai commented on the issue:
https://github.com/apache/spark/pull/15857
```
[error] [warn]
/home/jenkins/workspace/spark-master-compile-sbt-scala-2.10/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala:439:
Cannot check match for unreachability.
[error] (The analysis required more space than allowed. Please try with
scalac -Dscalac.patmat.analysisBudget=512 or
-Dscalac.patmat.analysisBudget=off.)
[error] [warn] CleanupAliases(plan.transformUp {
[error] [warn]
[error] [warn]
/home/jenkins/workspace/spark-master-compile-sbt-scala-2.10/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala:439:
Cannot check match for unreachability.
[error] (The analysis required more space than allowed. Please try with
scalac -Dscalac.patmat.analysisBudget=512 or
-Dscalac.patmat.analysisBudget=off.)
[error] [warn] CleanupAliases(plan.transformUp {
[error] [warn]
java.lang.RuntimeException: 2 fatal warnings
at scala.sys.package$.error(package.scala:27)
at SparkBuild$$anonfun$sharedSettings$18.apply(SparkBuild.scala:333)
at SparkBuild$$anonfun$sharedSettings$18.apply(SparkBuild.scala:302)
at scala.Function1$$anonfun$compose$1.apply(Function1.scala:47)
at sbt.$tilde$greater$$anonfun$$u2219$1.apply(TypeFunctions.scala:40)
at sbt.std.Transform$$anon$4.work(System.scala:63)
at
sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:228)
at
sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:228)
at sbt.ErrorHandling$.wideConvert(ErrorHandling.scala:17)
at sbt.Execute.work(Execute.scala:237)
at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:228)
at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:228)
at
sbt.ConcurrentRestrictions$$anon$4$$anonfun$1.apply(ConcurrentRestrictions.scala:159)
at sbt.CompletionService$$anon$2.call(CompletionService.scala:28)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
[error] (catalyst/compile:compile) 2 fatal warnings
[error] Total time: 190 s, completed Nov 15, 2016 7:11:45 AM
Build step 'Execute shell' marked build as failure
Finished: FAILURE
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15857: [SPARK-18300][SQL] Do not apply foldable propagation wit...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15857 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15857: [SPARK-18300][SQL] Do not apply foldable propagation wit...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15857 **[Test build #68661 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68661/consoleFull)** for PR 15857 at commit [`265051f`](https://github.com/apache/spark/commit/265051fa8ff1b592a7204b01729ec659cb8c7252). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15857: [SPARK-18300][SQL] Do not apply foldable propagation wit...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15857 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68661/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15857: [SPARK-18300][SQL] Do not apply foldable propagation wit...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15857 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15857: [SPARK-18300][SQL] Do not apply foldable propagation wit...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/15857 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15857: [SPARK-18300][SQL] Do not apply foldable propagation wit...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15857 **[Test build #68661 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68661/consoleFull)** for PR 15857 at commit [`265051f`](https://github.com/apache/spark/commit/265051fa8ff1b592a7204b01729ec659cb8c7252). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15857: [SPARK-18300][SQL] Do not apply foldable propagation wit...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15857 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68617/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15857: [SPARK-18300][SQL] Do not apply foldable propagation wit...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15857 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15857: [SPARK-18300][SQL] Do not apply foldable propagation wit...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15857 **[Test build #68617 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68617/consoleFull)** for PR 15857 at commit [`8ae0fd1`](https://github.com/apache/spark/commit/8ae0fd11a1ec47b17504f8afb2fb1387f9e74ded). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15857: [SPARK-18300][SQL] Do not apply foldable propagation wit...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15857 **[Test build #68617 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68617/consoleFull)** for PR 15857 at commit [`8ae0fd1`](https://github.com/apache/spark/commit/8ae0fd11a1ec47b17504f8afb2fb1387f9e74ded). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15857: [SPARK-18300][SQL] Do not apply foldable propagation wit...
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15857
The test case [test("Propagate in subqueries of Union
queries")](https://github.com/hvanhovell/spark/blob/d98f8f930330b368fbeade07d435197b0cdd2228/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FoldablePropagationSuite.scala#L116-L130)
is not resolvable. Thus, we do not have a test case to verify whether the
propagation is stopped by
[`Union`](https://github.com/hvanhovell/spark/blob/d98f8f930330b368fbeade07d435197b0cdd2228/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala#L440-L442).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15857: [SPARK-18300][SQL] Do not apply foldable propagation wit...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15857 Could we add a comment above [`Union`](https://github.com/hvanhovell/spark/blob/d98f8f930330b368fbeade07d435197b0cdd2228/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala#L440) to explain why `Except` and `Intersect` are not handled? You know, my first reaction is why only handling `Union`? How about `Except` and `Intersect`? Then, I realize they have been replaced before this rule. That means, the order of these rules matters. : ) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15857: [SPARK-18300][SQL] Do not apply foldable propagation wit...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15857 It looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15857: [SPARK-18300][SQL] Do not apply foldable propagation wit...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15857 Thank you for pining me, @gatorsmile . Thank you for fixing this, @hvanhovell . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15857: [SPARK-18300][SQL] Do not apply foldable propagation wit...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15857 cc @dongjoon-hyun @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15857: [SPARK-18300][SQL] Do not apply foldable propagation wit...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15857 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15857: [SPARK-18300][SQL] Do not apply foldable propagation wit...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15857 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68543/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15857: [SPARK-18300][SQL] Do not apply foldable propagation wit...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15857 **[Test build #68543 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68543/consoleFull)** for PR 15857 at commit [`d98f8f9`](https://github.com/apache/spark/commit/d98f8f930330b368fbeade07d435197b0cdd2228). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15857: [SPARK-18300][SQL] Do not apply foldable propagation wit...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15857 **[Test build #68543 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68543/consoleFull)** for PR 15857 at commit [`d98f8f9`](https://github.com/apache/spark/commit/d98f8f930330b368fbeade07d435197b0cdd2228). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
