[GitHub] spark issue #15865: [SPARK-18420][BUILD] Fix the errors caused by lint check...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15865 Merged to master/2.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15865: [SPARK-18420][BUILD] Fix the errors caused by lint check...
Github user ConeyLiu commented on the issue: https://github.com/apache/spark/pull/15865 @HyukjinKwon @srowen Thank you very much. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15865: [SPARK-18420][BUILD] Fix the errors caused by lint check...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15865 I just checked for sure. ``` $ ./dev/lint-java Using `mvn` from path: .../mvn Checkstyle checks passed. ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15865: [SPARK-18420][BUILD] Fix the errors caused by lint check...
Github user ConeyLiu commented on the issue: https://github.com/apache/spark/pull/15865 @srowen hi owen, Can you give me some advice, and if so, what a great thing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15865: [SPARK-18420][BUILD] Fix the errors caused by lint check...
Github user ConeyLiu commented on the issue: https://github.com/apache/spark/pull/15865 @HyukjinKwon I'm sorry for so late reply. I update the code and style followed by your suggestion, that's so useful. And also I change the method of disabling the check around `finalize`. Please take a loot or give some suggestion. Thanks a lot. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15865: [SPARK-18420][BUILD] Fix the errors caused by lint check...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15865 For sure, I ran ```bash $ ./dev/lint-java Using `mvn` from path: .../mvn Checkstyle checks passed. ``` It seems fine. It looks good to me for few minor comments above. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15865: [SPARK-18420][BUILD] Fix the errors caused by lint check...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15865 **[Test build #3425 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3425/consoleFull)** for PR 15865 at commit [`39c2a85`](https://github.com/apache/spark/commit/39c2a851d62527d933f5351454199950e64b19fc). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15865: [SPARK-18420][BUILD] Fix the errors caused by lint check...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15865 **[Test build #3425 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3425/consoleFull)** for PR 15865 at commit [`39c2a85`](https://github.com/apache/spark/commit/39c2a851d62527d933f5351454199950e64b19fc). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15865: [SPARK-18420][BUILD] Fix the errors caused by lint check...
Github user ConeyLiu commented on the issue: https://github.com/apache/spark/pull/15865 @HyukjinKwon Thanks for the review and suggestion, I've updated it. Clear the unused object `hasher` and add suppression rules for the method `finalize` of `NioBufferedFileInputStream`. Please take a look, thanks a lot. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
