[GitHub] spark issue #15883: [SPARK-18438][SPARKR][ML] spark.mlp should support RForm...
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/15883 Merged into master and branch-2.1. Thanks for reviewing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15883: [SPARK-18438][SPARKR][ML] spark.mlp should support RForm...
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/15883 Yes thanks LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15883: [SPARK-18438][SPARKR][ML] spark.mlp should support RForm...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15883 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15883: [SPARK-18438][SPARKR][ML] spark.mlp should support RForm...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15883 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68690/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15883: [SPARK-18438][SPARKR][ML] spark.mlp should support RForm...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15883 **[Test build #68690 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68690/consoleFull)** for PR 15883 at commit [`96a0c2a`](https://github.com/apache/spark/commit/96a0c2af5b97ad599f648653736001af07a5f15d). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15883: [SPARK-18438][SPARKR][ML] spark.mlp should support RForm...
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/15883 @felixcheung Both ```paste``` and ```paste0``` should work well in this scenario, since ```RFormula``` can handle space between each term. I think it would be better to unify them, so I use ```paste``` across ```mllib.R```. Any more comments? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15883: [SPARK-18438][SPARKR][ML] spark.mlp should support RForm...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15883 **[Test build #68690 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68690/consoleFull)** for PR 15883 at commit [`96a0c2a`](https://github.com/apache/spark/commit/96a0c2af5b97ad599f648653736001af07a5f15d). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15883: [SPARK-18438][SPARKR][ML] spark.mlp should support RForm...
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/15883 try my comment suggestion - it should fix the error re: `paste0` it looks like there are more `paste` than `paste0`? perhaps we shouldn't change it then? what do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15883: [SPARK-18438][SPARKR][ML] spark.mlp should support RForm...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15883 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68657/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15883: [SPARK-18438][SPARKR][ML] spark.mlp should support RForm...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15883 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15883: [SPARK-18438][SPARKR][ML] spark.mlp should support RForm...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15883 **[Test build #68657 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68657/consoleFull)** for PR 15883 at commit [`4a2ec9c`](https://github.com/apache/spark/commit/4a2ec9c7c83b787b401c74de24fe1967fe77f2c0). * This patch **fails SparkR unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15883: [SPARK-18438][SPARKR][ML] spark.mlp should support RForm...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15883 **[Test build #68656 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68656/consoleFull)** for PR 15883 at commit [`92d127b`](https://github.com/apache/spark/commit/92d127bc32a44d73c44fd5f41fbd38e03e3ee545). * This patch **fails SparkR unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15883: [SPARK-18438][SPARKR][ML] spark.mlp should support RForm...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15883 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68656/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15883: [SPARK-18438][SPARKR][ML] spark.mlp should support RForm...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15883 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15883: [SPARK-18438][SPARKR][ML] spark.mlp should support RForm...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15883 **[Test build #68657 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68657/consoleFull)** for PR 15883 at commit [`4a2ec9c`](https://github.com/apache/spark/commit/4a2ec9c7c83b787b401c74de24fe1967fe77f2c0). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15883: [SPARK-18438][SPARKR][ML] spark.mlp should support RForm...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15883 **[Test build #68656 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68656/consoleFull)** for PR 15883 at commit [`92d127b`](https://github.com/apache/spark/commit/92d127bc32a44d73c44fd5f41fbd38e03e3ee545). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15883: [SPARK-18438][SPARKR][ML] spark.mlp should support RForm...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15883 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68650/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15883: [SPARK-18438][SPARKR][ML] spark.mlp should support RForm...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15883 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15883: [SPARK-18438][SPARKR][ML] spark.mlp should support RForm...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15883 **[Test build #68650 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68650/consoleFull)** for PR 15883 at commit [`56a58fa`](https://github.com/apache/spark/commit/56a58fa22fd2243c536f71bca78ec65a15a44ecc). * This patch **fails SparkR unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15883: [SPARK-18438][SPARKR][ML] spark.mlp should support RForm...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15883 **[Test build #68650 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68650/consoleFull)** for PR 15883 at commit [`56a58fa`](https://github.com/apache/spark/commit/56a58fa22fd2243c536f71bca78ec65a15a44ecc). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15883: [SPARK-18438][SPARKR][ML] spark.mlp should support RForm...
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/15883 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15883: [SPARK-18438][SPARKR][ML] spark.mlp should support RForm...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15883 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15883: [SPARK-18438][SPARKR][ML] spark.mlp should support RForm...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15883 **[Test build #68622 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68622/consoleFull)** for PR 15883 at commit [`56a58fa`](https://github.com/apache/spark/commit/56a58fa22fd2243c536f71bca78ec65a15a44ecc). * This patch **fails SparkR unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15883: [SPARK-18438][SPARKR][ML] spark.mlp should support RForm...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15883 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68622/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15883: [SPARK-18438][SPARKR][ML] spark.mlp should support RForm...
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/15883 cc @felixcheung --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15883: [SPARK-18438][SPARKR][ML] spark.mlp should support RForm...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15883 **[Test build #68622 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68622/consoleFull)** for PR 15883 at commit [`56a58fa`](https://github.com/apache/spark/commit/56a58fa22fd2243c536f71bca78ec65a15a44ecc). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
