[GitHub] spark issue #15935: [SPARK-18188] add checksum for blocks of broadcast
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/15935 LGTM. Merging to master and 2.1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15935: [SPARK-18188] add checksum for blocks of broadcast
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15935 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69299/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15935: [SPARK-18188] add checksum for blocks of broadcast
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15935 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15935: [SPARK-18188] add checksum for blocks of broadcast
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15935 **[Test build #69299 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69299/consoleFull)** for PR 15935 at commit [`5c56974`](https://github.com/apache/spark/commit/5c56974f3e366688fc4c8fa2909a411788b03a1d). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15935: [SPARK-18188] add checksum for blocks of broadcast
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15935 **[Test build #69299 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69299/consoleFull)** for PR 15935 at commit [`5c56974`](https://github.com/apache/spark/commit/5c56974f3e366688fc4c8fa2909a411788b03a1d). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15935: [SPARK-18188] add checksum for blocks of broadcast
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/15935 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15935: [SPARK-18188] add checksum for blocks of broadcast
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15935 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69274/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15935: [SPARK-18188] add checksum for blocks of broadcast
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15935 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15935: [SPARK-18188] add checksum for blocks of broadcast
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15935 **[Test build #69274 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69274/consoleFull)** for PR 15935 at commit [`5c56974`](https://github.com/apache/spark/commit/5c56974f3e366688fc4c8fa2909a411788b03a1d). * This patch **fails from timeout after a configured wait of \`250m\`**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15935: [SPARK-18188] add checksum for blocks of broadcast
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15935 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69264/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15935: [SPARK-18188] add checksum for blocks of broadcast
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15935 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15935: [SPARK-18188] add checksum for blocks of broadcast
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15935 **[Test build #69264 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69264/consoleFull)** for PR 15935 at commit [`c17e0b1`](https://github.com/apache/spark/commit/c17e0b15c7e2c859ce67fcf4e3365e467900802c). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15935: [SPARK-18188] add checksum for blocks of broadcast
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/15935 LGTM pending tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15935: [SPARK-18188] add checksum for blocks of broadcast
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15935 **[Test build #69274 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69274/consoleFull)** for PR 15935 at commit [`5c56974`](https://github.com/apache/spark/commit/5c56974f3e366688fc4c8fa2909a411788b03a1d). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15935: [SPARK-18188] add checksum for blocks of broadcast
Github user davies commented on the issue: https://github.com/apache/spark/pull/15935 @zsxwing Added. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15935: [SPARK-18188] add checksum for blocks of broadcast
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/15935 Can we add a flag for this feature so that people can disable it if their network is stable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15935: [SPARK-18188] add checksum for blocks of broadcast
Github user davies commented on the issue: https://github.com/apache/spark/pull/15935 Manually test this patch with a job that usually failed with corrupt streams: ``` 136 26993 0 FAILED PROCESS_LOCAL 0 / 10.1.108.161 2016/11/20 08:39:11 7 s 98 ms 0 ms30.1 MB / 14481129.2 MB java.io.IOException: org.apache.spark.SparkException: corrupt remote block 9: 927759120 != 787315496 +details java.io.IOException: org.apache.spark.SparkException: corrupt remote block 9: 927759120 != 787315496 at org.apache.spark.util.Utils$.tryOrIOException(Utils.scala:1283) at org.apache.spark.broadcast.TorrentBroadcast.readBroadcastBlock(TorrentBroadcast.scala:192) at org.apache.spark.broadcast.TorrentBroadcast._value$lzycompute(TorrentBroadcast.scala:66) at org.apache.spark.broadcast.TorrentBroadcast._value(TorrentBroadcast.scala:66) at org.apache.spark.broadcast.TorrentBroadcast.getValue(TorrentBroadcast.scala:93) at org.apache.spark.broadcast.Broadcast.value(Broadcast.scala:70) at org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIterator.init(Unknown Source) at org.apache.spark.sql.execution.WholeStageCodegenExec$$anonfun$8.apply(WholeStageCodegenExec.scala:367) at org.apache.spark.sql.execution.WholeStageCodegenExec$$anonfun$8.apply(WholeStageCodegenExec.scala:364) at org.apache.spark.rdd.RDD$$anonfun$mapPartitionsWithIndex$1$$anonfun$apply$25.apply(RDD.scala:820) at org.apache.spark.rdd.RDD$$anonfun$mapPartitionsWithIndex$1$$anonfun$apply$25.apply(RDD.scala:820) at org.apache.spark.rdd.MapPartitionsRDD.compute(MapPartitionsRDD.scala:38) at org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:319) at org.apache.spark.rdd.RDD.iterator(RDD.scala:283) at org.apache.spark.rdd.MapPartitionsRDD.compute(MapPartitionsRDD.scala:38) at org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:319) at org.apache.spark.rdd.RDD.iterator(RDD.scala:283) at org.apache.spark.rdd.MapPartitionsRDD.compute(MapPartitionsRDD.scala:38) at org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:319) at org.apache.spark.rdd.RDD.iterator(RDD.scala:283) at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:70) at org.apache.spark.scheduler.Task.run(Task.scala:86) at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:274) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745) Caused by: org.apache.spark.SparkException: corrupt remote block 9: 927759120 != 787315496 at org.apache.spark.broadcast.TorrentBroadcast$$anonfun$org$apache$spark$broadcast$TorrentBroadcast$$readBlocks$1.apply$mcVI$sp(TorrentBroadcast.scala:154) at org.apache.spark.broadcast.TorrentBroadcast$$anonfun$org$apache$spark$broadcast$TorrentBroadcast$$readBlocks$1.apply(TorrentBroadcast.scala:139) at org.apache.spark.broadcast.TorrentBroadcast$$anonfun$org$apache$spark$broadcast$TorrentBroadcast$$readBlocks$1.apply(TorrentBroadcast.scala:139) at scala.collection.immutable.List.foreach(List.scala:318) at org.apache.spark.broadcast.TorrentBroadcast.org$apache$spark$broadcast$TorrentBroadcast$$readBlocks(TorrentBroadcast.scala:139) at org.apache.spark.broadcast.TorrentBroadcast$$anonfun$readBroadcastBlock$1.apply(TorrentBroadcast.scala:204) at org.apache.spark.util.Utils$.tryOrIOException(Utils.scala:1276) ... 25 more 136 27059 1 SUCCESS PROCESS_LOCAL 13 / 10.1.109.49 2016/11/20 08:39:23 19 s0.4 s 1 ms30.1 MB / 14481128.9 MB ``` This patch did save a stage from a corrupt block of broadcast. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15935: [SPARK-18188] add checksum for blocks of broadcast
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15935 **[Test build #69264 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69264/consoleFull)** for PR 15935 at commit [`c17e0b1`](https://github.com/apache/spark/commit/c17e0b15c7e2c859ce67fcf4e3365e467900802c). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15935: [SPARK-18188] add checksum for blocks of broadcast
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15935 cc @joshrosen and @zsxwing too --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15935: [SPARK-18188] add checksum for blocks of broadcast
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15935 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15935: [SPARK-18188] add checksum for blocks of broadcast
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15935 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68874/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15935: [SPARK-18188] add checksum for blocks of broadcast
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15935 **[Test build #68874 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68874/consoleFull)** for PR 15935 at commit [`328ca39`](https://github.com/apache/spark/commit/328ca390f10cceeb21656eb4fb9e0ef677fd0672). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15935: [SPARK-18188] add checksum for blocks of broadcast
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15935 **[Test build #68874 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68874/consoleFull)** for PR 15935 at commit [`328ca39`](https://github.com/apache/spark/commit/328ca390f10cceeb21656eb4fb9e0ef677fd0672). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
