[GitHub] spark issue #15980: [SPARK-18528][SQL] Fix a bug to initialise an iterator o...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15980 LGTM. Merging to master/2.1/2.0. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15980: [SPARK-18528][SQL] Fix a bug to initialise an iterator o...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15980 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15980: [SPARK-18528][SQL] Fix a bug to initialise an iterator o...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15980 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70496/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15980: [SPARK-18528][SQL] Fix a bug to initialise an iterator o...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15980 **[Test build #70496 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70496/testReport)** for PR 15980 at commit [`64849e3`](https://github.com/apache/spark/commit/64849e3901aa59404480f1e406fe03d43053c2fe). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15980: [SPARK-18528][SQL] Fix a bug to initialise an iterator o...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15980 **[Test build #70496 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70496/testReport)** for PR 15980 at commit [`64849e3`](https://github.com/apache/spark/commit/64849e3901aa59404480f1e406fe03d43053c2fe). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15980: [SPARK-18528][SQL] Fix a bug to initialise an iterator o...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15980 I'll merge this after another test run. Ping me if you have objections. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15980: [SPARK-18528][SQL] Fix a bug to initialise an iterator o...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15980 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15980: [SPARK-18528][SQL] Fix a bug to initialise an iterator o...
Github user davies commented on the issue: https://github.com/apache/spark/pull/15980 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15980: [SPARK-18528][SQL] Fix a bug to initialise an iterator o...
Github user maropu commented on the issue: https://github.com/apache/spark/pull/15980 @davies How about this fix? I think it seems to be difficult to put the `earlyStop` flag in `shouldStop()` because `shouldStop()` is used for a caller (an uppper `SparkPlan`) to exit a loop for fetchting output row-by-row in `processNext()`. If a LIMIT plan sets true at `earlyStop`, `shouldStop` always returns true and pre-aggregation wrongly breaks in the middle of `$doAgg`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15980: [SPARK-18528][SQL] Fix a bug to initialise an iterator o...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15980 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69132/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15980: [SPARK-18528][SQL] Fix a bug to initialise an iterator o...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15980 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15980: [SPARK-18528][SQL] Fix a bug to initialise an iterator o...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15980 **[Test build #69132 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69132/consoleFull)** for PR 15980 at commit [`64849e3`](https://github.com/apache/spark/commit/64849e3901aa59404480f1e406fe03d43053c2fe). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15980: [SPARK-18528][SQL] Fix a bug to initialise an iterator o...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15980 **[Test build #69132 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69132/consoleFull)** for PR 15980 at commit [`64849e3`](https://github.com/apache/spark/commit/64849e3901aa59404480f1e406fe03d43053c2fe). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15980: [SPARK-18528][SQL] Fix a bug to initialise an iterator o...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15980 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15980: [SPARK-18528][SQL] Fix a bug to initialise an iterator o...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15980 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69078/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15980: [SPARK-18528][SQL] Fix a bug to initialise an iterator o...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15980 **[Test build #69078 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69078/consoleFull)** for PR 15980 at commit [`262c80b`](https://github.com/apache/spark/commit/262c80bccc1050f506bf44e8398263995f3ba177). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15980: [SPARK-18528][SQL] Fix a bug to initialise an iterator o...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15980 **[Test build #69078 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69078/consoleFull)** for PR 15980 at commit [`262c80b`](https://github.com/apache/spark/commit/262c80bccc1050f506bf44e8398263995f3ba177). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15980: [SPARK-18528][SQL] Fix a bug to initialise an iterator o...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15980 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69022/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15980: [SPARK-18528][SQL] Fix a bug to initialise an iterator o...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15980 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15980: [SPARK-18528][SQL] Fix a bug to initialise an iterator o...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15980 **[Test build #69022 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69022/consoleFull)** for PR 15980 at commit [`31cf318`](https://github.com/apache/spark/commit/31cf318358365fcd237fd9a9ec4f3125996f7e3e). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15980: [SPARK-18528][SQL] Fix a bug to initialise an iterator o...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15980 cc @davies --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15980: [SPARK-18528][SQL] Fix a bug to initialise an iterator o...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15980 **[Test build #69022 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69022/consoleFull)** for PR 15980 at commit [`31cf318`](https://github.com/apache/spark/commit/31cf318358365fcd237fd9a9ec4f3125996f7e3e). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org