[GitHub] spark issue #16020: [SPARK-18596][ML] add checking and caching to bisecting ...

[hhbyyh]

Github user hhbyyh commented on the issue:

https://github.com/apache/spark/pull/16020
  
Close this as it's better resolved in 
https://issues.apache.org/jira/browse/SPARK-18608.
Thanks for the comments and discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #16020: [SPARK-18596][ML] add checking and caching to bisecting ...

[hhbyyh]

Github user hhbyyh commented on the issue:

https://github.com/apache/spark/pull/16020
  
@MLnick Do you think we still need the event listener unit test? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #16020: [SPARK-18596][ML] add checking and caching to bisecting ...

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/16020
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #16020: [SPARK-18596][ML] add checking and caching to bisecting ...

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/16020
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69582/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #16020: [SPARK-18596][ML] add checking and caching to bisecting ...

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/16020
  
**[Test build #69582 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69582/consoleFull)**
 for PR 16020 at commit 
[`678cd43`](https://github.com/apache/spark/commit/678cd43321e98a20968e7d4ede561792d578dde4).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #16020: [SPARK-18596][ML] add checking and caching to bisecting ...

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/16020
  
**[Test build #69582 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69582/consoleFull)**
 for PR 16020 at commit 
[`678cd43`](https://github.com/apache/spark/commit/678cd43321e98a20968e7d4ede561792d578dde4).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #16020: [SPARK-18596][ML] add checking and caching to bisecting ...

[hhbyyh]

Github user hhbyyh commented on the issue:

https://github.com/apache/spark/pull/16020
  
I just added a straight forward check for the data frame cache level. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #16020: [SPARK-18596][ML] add checking and caching to bisecting ...

[MLnick]

Github user MLnick commented on the issue:

https://github.com/apache/spark/pull/16020
  
Yes unit tests would be good to add.

Tests may require using event listeners to check the caching of the
intermediate dataset with/without cached initial data. Or at least that is
the only way I thought of so far ...
On Fri, 2 Dec 2016 at 20:01, Yuhao Yang  wrote:

> Sure we can change KMeans as well. And perhaps we can also add some unit
> tests. I'll send update.
>
> —
> You are receiving this because you commented.
>
>
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #16020: [SPARK-18596][ML] add checking and caching to bisecting ...

[hhbyyh]

Github user hhbyyh commented on the issue:

https://github.com/apache/spark/pull/16020
  
Sure we can change KMeans as well. And perhaps we can also add some unit 
tests. I'll send update.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #16020: [SPARK-18596][ML] add checking and caching to bisecting ...

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/16020
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #16020: [SPARK-18596][ML] add checking and caching to bisecting ...

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/16020
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69247/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #16020: [SPARK-18596][ML] add checking and caching to bisecting ...

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/16020
  
**[Test build #69247 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69247/consoleFull)**
 for PR 16020 at commit 
[`0105220`](https://github.com/apache/spark/commit/0105220c27e6ddadef91b5ea2cb448865bfe79a6).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #16020: [SPARK-18596][ML] add checking and caching to bisecting ...

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/16020
  
**[Test build #69247 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69247/consoleFull)**
 for PR 16020 at commit 
[`0105220`](https://github.com/apache/spark/commit/0105220c27e6ddadef91b5ea2cb448865bfe79a6).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #16020: [SPARK-18596][ML] add checking and caching to bisecting ...

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/16020
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69198/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #16020: [SPARK-18596][ML] add checking and caching to bisecting ...

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/16020
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #16020: [SPARK-18596][ML] add checking and caching to bisecting ...

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/16020
  
**[Test build #69198 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69198/consoleFull)**
 for PR 16020 at commit 
[`a4c88ee`](https://github.com/apache/spark/commit/a4c88ee89f175c0672eeebe004ef3ac87a7a464a).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #16020: [SPARK-18596][ML] add checking and caching to bisecting ...

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/16020
  
**[Test build #69198 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69198/consoleFull)**
 for PR 16020 at commit 
[`a4c88ee`](https://github.com/apache/spark/commit/a4c88ee89f175c0672eeebe004ef3ac87a7a464a).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org