[GitHub] spark issue #16031: [SPARK-18606][HISTORYSERVER]remove useless elements whil...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16031 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16031: [SPARK-18606][HISTORYSERVER]remove useless elements whil...
Github user WangTaoTheTonic commented on the issue: https://github.com/apache/spark/pull/16031 I agree with you @ajbozarth. Since only one column uses `replace` function we can keep it same as now. If there is more data using this function in the future we will extract it to a simple file or something :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16031: [SPARK-18606][HISTORYSERVER]remove useless elements whil...
Github user ajbozarth commented on the issue: https://github.com/apache/spark/pull/16031 Since you've checked and it doesn't work then this generally **LGTM**, but I still find it odd that jQuery can't do this for us. Also, it's not important now, but we may want to eventually pull the actual `replace` function into a common file since other pages might need to use it as well when we switch them to DataTables. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16031: [SPARK-18606][HISTORYSERVER]remove useless elements whil...
Github user WangTaoTheTonic commented on the issue: https://github.com/apache/spark/pull/16031 @srowen @ajbozarth Sorry for the delay. I've tried the solution, but found it didn't work, as we already defined the type(`appid-numeric`) which will override value of `sType`. I checked the implementation of `html` sType, it is same with what I proposed in this patch. Here I pasted snapshot: ![226c5a24-d87f-480d-ad00-6c4a4b30560f](https://cloud.githubusercontent.com/assets/5276001/21044121/471b8c12-be35-11e6-96ba-621a31ed3ec9.png) ![924f3273-ae3e-403d-ad9b-4cf00a9d50fc](https://cloud.githubusercontent.com/assets/5276001/21044130/4e4a5590-be35-11e6-85ee-a02b4b042aa0.png) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16031: [SPARK-18606][HISTORYSERVER]remove useless elements whil...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16031 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69239/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16031: [SPARK-18606][HISTORYSERVER]remove useless elements whil...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16031 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16031: [SPARK-18606][HISTORYSERVER]remove useless elements whil...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16031 **[Test build #69239 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69239/consoleFull)** for PR 16031 at commit [`37aa3a2`](https://github.com/apache/spark/commit/37aa3a2d2fddfa46fb4c5427cebed5683530153d). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16031: [SPARK-18606][HISTORYSERVER]remove useless elements whil...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16031 **[Test build #69239 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69239/consoleFull)** for PR 16031 at commit [`37aa3a2`](https://github.com/apache/spark/commit/37aa3a2d2fddfa46fb4c5427cebed5683530153d). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org