[GitHub] spark issue #16080: [SPARK-18647][SQL] do not put provider in table properti...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16080 thanks for the review, merging to master/2.1! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16080: [SPARK-18647][SQL] do not put provider in table properti...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16080 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69535/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16080: [SPARK-18647][SQL] do not put provider in table properti...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16080 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16080: [SPARK-18647][SQL] do not put provider in table properti...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16080 **[Test build #69535 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69535/consoleFull)** for PR 16080 at commit [`00bdeff`](https://github.com/apache/spark/commit/00bdeff05faf542631d03c939f05842fbe89b71e). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16080: [SPARK-18647][SQL] do not put provider in table properti...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16080 @cloud-fan True. That is not the `oldTableDef` fetched from the metastore. LGTM pending test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16080: [SPARK-18647][SQL] do not put provider in table properti...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16080 **[Test build #69535 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69535/consoleFull)** for PR 16080 at commit [`00bdeff`](https://github.com/apache/spark/commit/00bdeff05faf542631d03c939f05842fbe89b71e). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16080: [SPARK-18647][SQL] do not put provider in table properti...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16080 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69525/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16080: [SPARK-18647][SQL] do not put provider in table properti...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16080 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16080: [SPARK-18647][SQL] do not put provider in table properti...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16080 **[Test build #69525 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69525/consoleFull)** for PR 16080 at commit [`3b81c33`](https://github.com/apache/spark/commit/3b81c33374b76604b8082ce4c5b5b10ea8f133cc). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16080: [SPARK-18647][SQL] do not put provider in table properti...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16080 **[Test build #69525 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69525/consoleFull)** for PR 16080 at commit [`3b81c33`](https://github.com/apache/spark/commit/3b81c33374b76604b8082ce4c5b5b10ea8f133cc). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16080: [SPARK-18647][SQL] do not put provider in table properti...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16080 @gatorsmile , `alterTable` don't need to change, the `provider` is not in table properties but still in the `CatalogTable.provider` field. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16080: [SPARK-18647][SQL] do not put provider in table properti...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16080 The [`alterTable`](https://github.com/cloud-fan/spark/blob/5ee6489cdd1c22a1071c4fb6c7e4c4af126c9d50/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala#L533) API in HiveExternalCatalog is still based on the provider field. We need a change too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16080: [SPARK-18647][SQL] do not put provider in table properti...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16080 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16080: [SPARK-18647][SQL] do not put provider in table properti...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16080 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69465/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16080: [SPARK-18647][SQL] do not put provider in table properti...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16080 **[Test build #69465 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69465/consoleFull)** for PR 16080 at commit [`5ee6489`](https://github.com/apache/spark/commit/5ee6489cdd1c22a1071c4fb6c7e4c4af126c9d50). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16080: [SPARK-18647][SQL] do not put provider in table properti...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16080 **[Test build #69465 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69465/consoleFull)** for PR 16080 at commit [`5ee6489`](https://github.com/apache/spark/commit/5ee6489cdd1c22a1071c4fb6c7e4c4af126c9d50). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16080: [SPARK-18647][SQL] do not put provider in table properti...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16080 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69459/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16080: [SPARK-18647][SQL] do not put provider in table properti...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16080 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16080: [SPARK-18647][SQL] do not put provider in table properti...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16080 **[Test build #69459 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69459/consoleFull)** for PR 16080 at commit [`198d273`](https://github.com/apache/spark/commit/198d2734936fdadb39bdc77dc223b4ee41c660ba). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16080: [SPARK-18647][SQL] do not put provider in table properti...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16080 **[Test build #69459 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69459/consoleFull)** for PR 16080 at commit [`198d273`](https://github.com/apache/spark/commit/198d2734936fdadb39bdc77dc223b4ee41c660ba). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16080: [SPARK-18647][SQL] do not put provider in table properti...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16080 I see. Will be careful in the future to not break the forward compatibility. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16080: [SPARK-18647][SQL] do not put provider in table properti...
Github user rxin commented on the issue: https://github.com/apache/spark/pull/16080 We can have a test to check the table properties don't contain the entry, can't we? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16080: [SPARK-18647][SQL] do not put provider in table properti...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16080 @rxin I'm afraid it's hard to write forward compatibility tests using unit test, we may need an external test infrastructure(python scripts) to do this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16080: [SPARK-18647][SQL] do not put provider in table properti...
Github user rxin commented on the issue: https://github.com/apache/spark/pull/16080 In a lot of environments people run multiple Spark versions side by side. That's always been a big strength of Spark. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16080: [SPARK-18647][SQL] do not put provider in table properti...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16080 We need to provide forward compatibility? That is pretty hard. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16080: [SPARK-18647][SQL] do not put provider in table properti...
Github user rxin commented on the issue: https://github.com/apache/spark/pull/16080 We need a test case here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16080: [SPARK-18647][SQL] do not put provider in table properti...
Github user mallman commented on the issue: https://github.com/apache/spark/pull/16080 I built and tested this branch, and it resolves the issue I was having with reading Spark 2.1 tables in earlier versions of Spark. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16080: [SPARK-18647][SQL] do not put provider in table properti...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16080 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16080: [SPARK-18647][SQL] do not put provider in table properti...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16080 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69406/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16080: [SPARK-18647][SQL] do not put provider in table properti...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16080 **[Test build #69406 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69406/consoleFull)** for PR 16080 at commit [`89f1625`](https://github.com/apache/spark/commit/89f1625b35ef21799e5d0d815dc18e23f3fd8106). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16080: [SPARK-18647][SQL] do not put provider in table properti...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16080 **[Test build #69406 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69406/consoleFull)** for PR 16080 at commit [`89f1625`](https://github.com/apache/spark/commit/89f1625b35ef21799e5d0d815dc18e23f3fd8106). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16080: [SPARK-18647][SQL] do not put provider in table properti...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16080 cc @rxin @yhuai @mallman --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
