[GitHub] spark issue #16103: [SPARK-18374][ML]Incorrect words in StopWords/english.tx...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16103 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16103: [SPARK-18374][ML]Incorrect words in StopWords/english.tx...
Github user hhbyyh commented on the issue: https://github.com/apache/spark/pull/16103 Thanks for the review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16103: [SPARK-18374][ML]Incorrect words in StopWords/english.tx...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16103 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69677/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16103: [SPARK-18374][ML]Incorrect words in StopWords/english.tx...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16103 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16103: [SPARK-18374][ML]Incorrect words in StopWords/english.tx...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16103 **[Test build #69677 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69677/consoleFull)** for PR 16103 at commit [`bd62396`](https://github.com/apache/spark/commit/bd623965bab15625b90fe3718614b346f4f6ce27). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16103: [SPARK-18374][ML]Incorrect words in StopWords/english.tx...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16103 **[Test build #69677 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69677/consoleFull)** for PR 16103 at commit [`bd62396`](https://github.com/apache/spark/commit/bd623965bab15625b90fe3718614b346f4f6ce27). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16103: [SPARK-18374][ML]Incorrect words in StopWords/english.tx...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16103 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16103: [SPARK-18374][ML]Incorrect words in StopWords/english.tx...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16103 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69675/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16103: [SPARK-18374][ML]Incorrect words in StopWords/english.tx...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16103 **[Test build #69675 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69675/consoleFull)** for PR 16103 at commit [`aa8c72a`](https://github.com/apache/spark/commit/aa8c72aca81d0b8f06912c30f15287a965da6c74). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16103: [SPARK-18374][ML]Incorrect words in StopWords/english.tx...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16103 **[Test build #69675 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69675/consoleFull)** for PR 16103 at commit [`aa8c72a`](https://github.com/apache/spark/commit/aa8c72aca81d0b8f06912c30f15287a965da6c74). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16103: [SPARK-18374][ML]Incorrect words in StopWords/english.tx...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16103 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69583/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16103: [SPARK-18374][ML]Incorrect words in StopWords/english.tx...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16103 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16103: [SPARK-18374][ML]Incorrect words in StopWords/english.tx...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16103 **[Test build #69583 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69583/consoleFull)** for PR 16103 at commit [`4cec57a`](https://github.com/apache/spark/commit/4cec57aa8cf6653098cbe09c68ce6a642cdde7ba). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16103: [SPARK-18374][ML]Incorrect words in StopWords/english.tx...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16103 **[Test build #69583 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69583/consoleFull)** for PR 16103 at commit [`4cec57a`](https://github.com/apache/spark/commit/4cec57aa8cf6653098cbe09c68ce6a642cdde7ba). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16103: [SPARK-18374][ML]Incorrect words in StopWords/english.tx...
Github user hhbyyh commented on the issue: https://github.com/apache/spark/pull/16103 Thanks @HyukjinKwon. I'll add them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16103: [SPARK-18374][ML]Incorrect words in StopWords/english.tx...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16103 Seems reasonable to me too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16103: [SPARK-18374][ML]Incorrect words in StopWords/english.tx...
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16103
Oh @hhbyyh, I think I am not used to this area but actually I just wanted
leave a comment just for stop words list that I considered for my elasticsearch
cluster before. I just made a list for missing ones via
```python
target =
open("mllib/src/main/resources/org/apache/spark/ml/feature/stopwords/english.txt").read().split("\n")
source = open("mylist.txt").read().split("\n")
for w in source:
if w not in target:
print w
```
and I got these below:
```
cannot
could
here's
how's
let's
ought
that's
there's
what's
when's
where's
who's
why's
would
```
I am not sure if they should be added here or not but I just wanted to let
you know what I considered before for stop words.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16103: [SPARK-18374][ML]Incorrect words in StopWords/english.tx...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16103 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69489/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16103: [SPARK-18374][ML]Incorrect words in StopWords/english.tx...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16103 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16103: [SPARK-18374][ML]Incorrect words in StopWords/english.tx...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16103 **[Test build #69489 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69489/consoleFull)** for PR 16103 at commit [`efeae8c`](https://github.com/apache/spark/commit/efeae8c8ab57ef77f9d8fd240e6ef9af626f947a). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16103: [SPARK-18374][ML]Incorrect words in StopWords/english.tx...
Github user hhbyyh commented on the issue: https://github.com/apache/spark/pull/16103 @srowen Thanks for the comments in jira. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16103: [SPARK-18374][ML]Incorrect words in StopWords/english.tx...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16103 **[Test build #69489 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69489/consoleFull)** for PR 16103 at commit [`efeae8c`](https://github.com/apache/spark/commit/efeae8c8ab57ef77f9d8fd240e6ef9af626f947a). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
