[GitHub] spark issue #16129: [SPARK-18678][ML] Skewed feature subsampling in Random f...
Github user sethah commented on the issue: https://github.com/apache/spark/pull/16129 This LGTM. Now that I'm looking at it, the test suite **never actually tests for correctness**, just basic input/output sizes. We really should have better tests, but it's ok with me if it's done in a separate JIRA. Also, I'd be in favor of changing the title since, while it does affect RandomForest/ML, it's really an error in the SamplingUtils, and this method is used in at least one other place (RangePartitioner). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16129: [SPARK-18678][ML] Skewed feature subsampling in Random f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16129 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16129: [SPARK-18678][ML] Skewed feature subsampling in Random f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16129 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69709/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16129: [SPARK-18678][ML] Skewed feature subsampling in Random f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16129 **[Test build #69709 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69709/consoleFull)** for PR 16129 at commit [`b4a197a`](https://github.com/apache/spark/commit/b4a197ac09e19693f6dc0ce9d50c32ce5064786f). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16129: [SPARK-18678][ML] Skewed feature subsampling in Random f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16129 **[Test build #69709 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69709/consoleFull)** for PR 16129 at commit [`b4a197a`](https://github.com/apache/spark/commit/b4a197ac09e19693f6dc0ce9d50c32ce5064786f). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16129: [SPARK-18678][ML] Skewed feature subsampling in Random f...
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/16129 > just paste in the new values this seems like the reasonable approach. your intuition and explanation make sense to me. thanks @srowen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16129: [SPARK-18678][ML] Skewed feature subsampling in Random f...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16129 @felixcheung maybe you can advise me on this. I think this is a correct fix, but ends up changing the results of decision forests a little bit. The SparkR test you wrote fails: ``` Failed - 1. Failure: spark.randomForest (@test_mllib.R#937) - predictions$prediction not equal to c(...). 16/16 mismatches (average diff: 0.108) [1] 60.3 - 60.4 == -0.0508 [2] 61.2 - 61.1 == 0.1272 [3] 60.7 - 60.6 == 0.0543 [4] 62.1 - 62.3 == -0.1473 [5] 63.5 - 63.7 == -0.2044 [6] 64.1 - 64.3 == -0.2413 [7] 65.1 - 64.9 == 0.2591 [8] 64.3 - 64.3 == 0.0045 [9] 66.7 - 66.7 == 0.0001 ... ``` Of course I can just paste in the new values, as I expect a small change in the result, but wanted to sense-check it. The new answers are closer to the answers in the nearly-identical case above with 1 tree, which seems a little positive. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16129: [SPARK-18678][ML] Skewed feature subsampling in Random f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16129 **[Test build #3467 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3467/consoleFull)** for PR 16129 at commit [`8ac5dee`](https://github.com/apache/spark/commit/8ac5dee8f9c0165da7a16d83d79f2f5080edb3ec). * This patch **fails SparkR unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16129: [SPARK-18678][ML] Skewed feature subsampling in Random f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16129 **[Test build #3467 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3467/consoleFull)** for PR 16129 at commit [`8ac5dee`](https://github.com/apache/spark/commit/8ac5dee8f9c0165da7a16d83d79f2f5080edb3ec). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16129: [SPARK-18678][ML] Skewed feature subsampling in Random f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16129 **[Test build #3466 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3466/consoleFull)** for PR 16129 at commit [`8ac5dee`](https://github.com/apache/spark/commit/8ac5dee8f9c0165da7a16d83d79f2f5080edb3ec). * This patch **fails SparkR unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16129: [SPARK-18678][ML] Skewed feature subsampling in Random f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16129 **[Test build #3466 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3466/consoleFull)** for PR 16129 at commit [`8ac5dee`](https://github.com/apache/spark/commit/8ac5dee8f9c0165da7a16d83d79f2f5080edb3ec). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16129: [SPARK-18678][ML] Skewed feature subsampling in Random f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16129 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16129: [SPARK-18678][ML] Skewed feature subsampling in Random f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16129 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69618/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16129: [SPARK-18678][ML] Skewed feature subsampling in Random f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16129 **[Test build #69618 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69618/consoleFull)** for PR 16129 at commit [`8ac5dee`](https://github.com/apache/spark/commit/8ac5dee8f9c0165da7a16d83d79f2f5080edb3ec). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16129: [SPARK-18678][ML] Skewed feature subsampling in Random f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16129 **[Test build #69618 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69618/consoleFull)** for PR 16129 at commit [`8ac5dee`](https://github.com/apache/spark/commit/8ac5dee8f9c0165da7a16d83d79f2f5080edb3ec). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
