[GitHub] spark issue #16215: [Streaming] Update PairDStreamFunctions.scala
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16215 I get it, it still seems not so worth it. The `DStream` API has always been mostly redundant with `foreachRDD` + the RDD API, and is itself maybe not something being actively updated anyway. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16215: [Streaming] Update PairDStreamFunctions.scala
Github user rxin commented on the issue: https://github.com/apache/spark/pull/16215 This is actually parity with PairRDDFunctions so I think it's OK to have them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16215: [Streaming] Update PairDStreamFunctions.scala
Github user Jimmy-Newtron commented on the issue: https://github.com/apache/spark/pull/16215 I think that this new API methods is going to bring consistency between PairRDDFunctions and PairDStreamFunctions by providing the same API to access the same data. I see the use case of a streaming application that is consuming a Kafka topic to retrieve the values as the simplest example of usage of this new API. I accept the PR rejection, even if the new API is matching only positive aspects of the Code Review Criteria. Positives: Adds functionality needed by a large number of users Simple, targeted Negatives, Risks: NONE Best regards --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16215: [Streaming] Update PairDStreamFunctions.scala
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16215 I don't think this worth new API methods since it's so easy to do this directly. Please see http://spark.apache.org/contributing.html too. I'd close this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16215: [Streaming] Update PairDStreamFunctions.scala
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16215 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
