[GitHub] spark issue #16225: [SPARK-14932][SQL] Allow DataFrame.replace() to replace ...
Github user bravo-zhang commented on the issue: https://github.com/apache/spark/pull/16225 @holdenk Thanks for review. I'll combine type(None) in the `isinstance`. I also made Scala and Python to accept null more generally and in the same way. PR is reopened at: https://github.com/apache/spark/pull/18820 @gatorsmile please also take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16225: [SPARK-14932][SQL] Allow DataFrame.replace() to replace ...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16225 We are closing it due to inactivity. please do reopen if you want to push it forward. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16225: [SPARK-14932][SQL] Allow DataFrame.replace() to replace ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16225 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77282/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16225: [SPARK-14932][SQL] Allow DataFrame.replace() to replace ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16225 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16225: [SPARK-14932][SQL] Allow DataFrame.replace() to replace ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16225 **[Test build #77282 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77282/testReport)** for PR 16225 at commit [`b5424d9`](https://github.com/apache/spark/commit/b5424d9fea56d2e0fb57ebc27d3d35054da6d22b). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16225: [SPARK-14932][SQL] Allow DataFrame.replace() to replace ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16225 **[Test build #77282 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77282/testReport)** for PR 16225 at commit [`b5424d9`](https://github.com/apache/spark/commit/b5424d9fea56d2e0fb57ebc27d3d35054da6d22b). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16225: [SPARK-14932][SQL] Allow DataFrame.replace() to replace ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16225 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77273/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16225: [SPARK-14932][SQL] Allow DataFrame.replace() to replace ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16225 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16225: [SPARK-14932][SQL] Allow DataFrame.replace() to replace ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16225 **[Test build #77273 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77273/testReport)** for PR 16225 at commit [`43fb6bd`](https://github.com/apache/spark/commit/43fb6bd56802f2c20cdd28f7ea384e472183cdc4). * This patch **fails PySpark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16225: [SPARK-14932][SQL] Allow DataFrame.replace() to replace ...
Github user bravo-zhang commented on the issue: https://github.com/apache/spark/pull/16225 Thanks for taking a look, @gatorsmile The conflicts have been resolved. I appreciate if @zero323 can take a look as well since you made improvement on this function recently. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16225: [SPARK-14932][SQL] Allow DataFrame.replace() to replace ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16225 **[Test build #77273 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77273/testReport)** for PR 16225 at commit [`43fb6bd`](https://github.com/apache/spark/commit/43fb6bd56802f2c20cdd28f7ea384e472183cdc4). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16225: [SPARK-14932][SQL] Allow DataFrame.replace() to replace ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16225 Build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16225: [SPARK-14932][SQL] Allow DataFrame.replace() to replace ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16225 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77261/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16225: [SPARK-14932][SQL] Allow DataFrame.replace() to replace ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16225 **[Test build #77261 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77261/consoleFull)** for PR 16225 at commit [`2c532c3`](https://github.com/apache/spark/commit/2c532c3781087ec8f0c36d5176837c9de568d7ec). * This patch passes all tests. * This patch **does not merge cleanly**. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16225: [SPARK-14932][SQL] Allow DataFrame.replace() to replace ...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16225 @bravo-zhang Could you resolve the conflicts? I will review it then. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16225: [SPARK-14932][SQL] Allow DataFrame.replace() to replace ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16225 **[Test build #77261 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77261/consoleFull)** for PR 16225 at commit [`2c532c3`](https://github.com/apache/spark/commit/2c532c3781087ec8f0c36d5176837c9de568d7ec). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16225: [SPARK-14932][SQL] Allow DataFrame.replace() to replace ...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16225 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16225: [SPARK-14932][SQL] Allow DataFrame.replace() to replace ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16225 **[Test build #3490 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3490/consoleFull)** for PR 16225 at commit [`0b15c8f`](https://github.com/apache/spark/commit/0b15c8f1d64754432c6585bb88e20d17738d4bbd). * This patch **fails Python style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16225: [SPARK-14932][SQL] Allow DataFrame.replace() to replace ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16225 **[Test build #3490 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3490/consoleFull)** for PR 16225 at commit [`0b15c8f`](https://github.com/apache/spark/commit/0b15c8f1d64754432c6585bb88e20d17738d4bbd). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16225: [SPARK-14932][SQL] Allow DataFrame.replace() to replace ...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16225 Would we need a test for Scala too? I checked this by myself and it seems working fine with Scala though. I could argue that this affects the language-specific functions of both Python and Scala as a not strong opinion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16225: [SPARK-14932][SQL] Allow DataFrame.replace() to replace ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16225 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
