[GitHub] spark issue #16235: [SPARK-18745][SQL] Fix signed integer overflow due to to...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16235 Merging to master/2.1. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16235: [SPARK-18745][SQL] Fix signed integer overflow due to to...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16235 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16235: [SPARK-18745][SQL] Fix signed integer overflow due to to...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16235 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69930/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16235: [SPARK-18745][SQL] Fix signed integer overflow due to to...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16235 **[Test build #69930 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69930/consoleFull)** for PR 16235 at commit [`7d2782f`](https://github.com/apache/spark/commit/7d2782f2d730b900dbe672f90d3ff3ccbeeb0882). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16235: [SPARK-18745][SQL] Fix signed integer overflow due to to...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16235 **[Test build #69930 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69930/consoleFull)** for PR 16235 at commit [`7d2782f`](https://github.com/apache/spark/commit/7d2782f2d730b900dbe672f90d3ff3ccbeeb0882). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16235: [SPARK-18745][SQL] Fix signed integer overflow due to to...
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/16235 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16235: [SPARK-18745][SQL] Fix signed integer overflow due to to...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16235 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69928/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16235: [SPARK-18745][SQL] Fix signed integer overflow due to to...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16235 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16235: [SPARK-18745][SQL] Fix signed integer overflow due to to...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16235 **[Test build #69928 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69928/consoleFull)** for PR 16235 at commit [`7d2782f`](https://github.com/apache/spark/commit/7d2782f2d730b900dbe672f90d3ff3ccbeeb0882). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16235: [SPARK-18745][SQL] Fix signed integer overflow due to to...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16235 It might at some point be an idea to add a bunch of asserts to `Platform`, that would make diagnoses a lot easier. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16235: [SPARK-18745][SQL] Fix signed integer overflow due to to...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16235 Ok, lets not do that for now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16235: [SPARK-18745][SQL] Fix signed integer overflow due to to...
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/16235 @hvanhovell if we want to test these methods, it seems to be complicated since we have to allocate large `array` by a naive approach that allocates `LongToUnsafeRowMap` and expands `array`. Another approach is to directly call private methods `writeLongArray` and `readLongArray` by using reflection. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16235: [SPARK-18745][SQL] Fix signed integer overflow due to to...
Github user davies commented on the issue: https://github.com/apache/spark/pull/16235 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16235: [SPARK-18745][SQL] Fix signed integer overflow due to to...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16235 **[Test build #69928 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69928/consoleFull)** for PR 16235 at commit [`7d2782f`](https://github.com/apache/spark/commit/7d2782f2d730b900dbe672f90d3ff3ccbeeb0882). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16235: [SPARK-18745][SQL] Fix signed integer overflow due to to...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16235 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16235: [SPARK-18745][SQL] Fix signed integer overflow due to to...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16235 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69926/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16235: [SPARK-18745][SQL] Fix signed integer overflow due to to...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16235 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16235: [SPARK-18745][SQL] Fix signed integer overflow due to to...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16235 **[Test build #69926 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69926/consoleFull)** for PR 16235 at commit [`7d2782f`](https://github.com/apache/spark/commit/7d2782f2d730b900dbe672f90d3ff3ccbeeb0882). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16235: [SPARK-18745][SQL] Fix signed integer overflow due to to...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16235 also cc @davies --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16235: [SPARK-18745][SQL] Fix signed integer overflow due to to...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16235 LGTM - pending jenkins. @kiszk do you think there is a sane way of testing this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16235: [SPARK-18745][SQL] Fix signed integer overflow due to to...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16235 **[Test build #69926 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69926/consoleFull)** for PR 16235 at commit [`7d2782f`](https://github.com/apache/spark/commit/7d2782f2d730b900dbe672f90d3ff3ccbeeb0882). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
