[GitHub] spark issue #16550: [SPARK-19178][SQL] convert string of large numbers to in...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16550 backported to 2.1/2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16550: [SPARK-19178][SQL] convert string of large numbers to in...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16550 Thanks! Merging to master. This JIRA is targeting to 2.2.0. Should we merge it to Spark 2.1? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16550: [SPARK-19178][SQL] convert string of large numbers to in...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16550 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71287/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16550: [SPARK-19178][SQL] convert string of large numbers to in...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16550 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16550: [SPARK-19178][SQL] convert string of large numbers to in...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16550 **[Test build #71287 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71287/testReport)** for PR 16550 at commit [`7448e8c`](https://github.com/apache/spark/commit/7448e8cff72c4510ab1b6f341c587a403779d5e9). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16550: [SPARK-19178][SQL] convert string of large numbers to in...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16550 **[Test build #71287 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71287/testReport)** for PR 16550 at commit [`7448e8c`](https://github.com/apache/spark/commit/7448e8cff72c4510ab1b6f341c587a403779d5e9). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16550: [SPARK-19178][SQL] convert string of large numbers to in...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16550 LGTM, after re-checking the corresponding Hive code and change history --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16550: [SPARK-19178][SQL] convert string of large numbers to in...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16550 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16550: [SPARK-19178][SQL] convert string of large numbers to in...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16550 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71261/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16550: [SPARK-19178][SQL] convert string of large numbers to in...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16550 **[Test build #71261 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71261/testReport)** for PR 16550 at commit [`beb4fd8`](https://github.com/apache/spark/commit/beb4fd82efd81852e742f75aee42313e99da763c). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16550: [SPARK-19178][SQL] convert string of large numbers to in...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16550 **[Test build #71261 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71261/testReport)** for PR 16550 at commit [`beb4fd8`](https://github.com/apache/spark/commit/beb4fd82efd81852e742f75aee42313e99da763c). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16550: [SPARK-19178][SQL] convert string of large numbers to in...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16550 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16550: [SPARK-19178][SQL] convert string of large numbers to in...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16550 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16550: [SPARK-19178][SQL] convert string of large numbers to in...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16550 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71250/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16550: [SPARK-19178][SQL] convert string of large numbers to in...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16550 **[Test build #71250 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71250/testReport)** for PR 16550 at commit [`beb4fd8`](https://github.com/apache/spark/commit/beb4fd82efd81852e742f75aee42313e99da763c). * This patch **fails PySpark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16550: [SPARK-19178][SQL] convert string of large numbers to in...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16550 **[Test build #71250 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71250/testReport)** for PR 16550 at commit [`beb4fd8`](https://github.com/apache/spark/commit/beb4fd82efd81852e742f75aee42313e99da763c). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16550: [SPARK-19178][SQL] convert string of large numbers to in...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16550 Be careful: the Chinese input `'â1'` is different from the English input `'-1'`. It is hard to distinguish. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16550: [SPARK-19178][SQL] convert string of large numbers to in...
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16550
Could you add the following test cases?
```SQL
SELECT CAST('' AS int);
-> NULL
SELECT CAST('' AS long);
-> NULL
SELECT CAST(NULL AS int);
-> NULL
SELECT CAST(NULL AS long);
-> NULL
SELECT CAST('123.a' AS int);
-> NULL
SELECT CAST('123.a' AS long);
-> NULL
// 2147483648 is the smallest INTEGER value (0x8000)
SELECT CAST('-2147483648' AS int);
-> -2147483648
SELECT CAST('-2147483649' AS int);
-> NULL
// 2147483647 is the largest INTEGER value (0x7FFF)
SELECT CAST('2147483647' AS int);
-> 2147483647
SELECT CAST('2147483648' AS int);
-> NULL
// â9223372036854775808 is the smallest INTEGER value (0x8000)
SELECT CAST('â9223372036854775808' AS long);
-> â9223372036854775808
SELECT CAST('â9223372036854775809' AS long);
-> NULL
// 9223372036854775807 is the largest LONG value (0x7FFF)
SELECT CAST('9223372036854775807' AS long);
-> 9223372036854775807
SELECT CAST('â9223372036854775808' AS long);
-> NULL
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16550: [SPARK-19178][SQL] convert string of large numbers to in...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16550 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71241/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16550: [SPARK-19178][SQL] convert string of large numbers to in...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16550 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16550: [SPARK-19178][SQL] convert string of large numbers to in...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16550 **[Test build #71241 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71241/testReport)** for PR 16550 at commit [`4e4ba95`](https://github.com/apache/spark/commit/4e4ba956c5bd3231f904f1fb9a6094e56155bac3). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16550: [SPARK-19178][SQL] convert string of large numbers to in...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16550 **[Test build #71241 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71241/testReport)** for PR 16550 at commit [`4e4ba95`](https://github.com/apache/spark/commit/4e4ba956c5bd3231f904f1fb9a6094e56155bac3). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16550: [SPARK-19178][SQL] convert string of large numbers to in...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16550 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16550: [SPARK-19178][SQL] convert string of large numbers to in...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16550 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71210/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16550: [SPARK-19178][SQL] convert string of large numbers to in...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16550 **[Test build #71210 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71210/testReport)** for PR 16550 at commit [`afa7066`](https://github.com/apache/spark/commit/afa7066b394217316789c06db467acf40c74cd28). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16550: [SPARK-19178][SQL] convert string of large numbers to in...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16550 **[Test build #71210 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71210/testReport)** for PR 16550 at commit [`afa7066`](https://github.com/apache/spark/commit/afa7066b394217316789c06db467acf40c74cd28). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16550: [SPARK-19178][SQL] convert string of large numbers to in...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16550 cc @yhuai @marmbrus @gatorsmile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
