[GitHub] spark issue #16572: [SPARK-18863][SQL] Output non-aggregate expressions with...
Github user nsyca commented on the issue: https://github.com/apache/spark/pull/16572 @hvanhovell, I agree it does look risky with this approach. There are a lot of dependencies here. I am pitching in the idea to get your initial thought. Let me do some background and I will share once I have a better idea on this approach. Thanks again for your time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16572: [SPARK-18863][SQL] Output non-aggregate expressions with...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16572 LGTM - merging to master/2.1/2.0. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16572: [SPARK-18863][SQL] Output non-aggregate expressions with...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16572 @nsyca it would be nice to make subquery expression part of tree traversal. It does seem risky to me, a lot functions using traversal maintain some state and do not account for the existence of subqueries, so I am a bit weary of trying this out (as it might break stuff in very subtle ways). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16572: [SPARK-18863][SQL] Output non-aggregate expressions with...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16572 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71960/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16572: [SPARK-18863][SQL] Output non-aggregate expressions with...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16572 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16572: [SPARK-18863][SQL] Output non-aggregate expressions with...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16572 **[Test build #71960 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71960/testReport)** for PR 16572 at commit [`010d27a`](https://github.com/apache/spark/commit/010d27a79be684668012fd796d21a085308dd828). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16572: [SPARK-18863][SQL] Output non-aggregate expressions with...
Github user nsyca commented on the issue: https://github.com/apache/spark/pull/16572 Thank you for your time reviewing this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16572: [SPARK-18863][SQL] Output non-aggregate expressions with...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16572 **[Test build #71960 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71960/testReport)** for PR 16572 at commit [`010d27a`](https://github.com/apache/spark/commit/010d27a79be684668012fd796d21a085308dd828). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16572: [SPARK-18863][SQL] Output non-aggregate expressions with...
Github user nsyca commented on the issue: https://github.com/apache/spark/pull/16572 Note the way the plans inside subqueries are not treated as part of the tree traversal is a common problem. Besides this problem, another was reported in SPARK-19093. Also the way Spark needs to implement a nested call to the Optimizer via the rule `OptimizedSubqueries` to work on those plans is another instance. One possible solution is to overwrite the tree traversal (`transformUp`, `transformDown`) of class `LogicalPlan` to include those subqueries' plans. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16572: [SPARK-18863][SQL] Output non-aggregate expressions with...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16572 Note that the diff is better to read using githubs `w=1` flag: https://github.com/apache/spark/pull/16572/files?w=1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16572: [SPARK-18863][SQL] Output non-aggregate expressions with...
Github user nsyca commented on the issue: https://github.com/apache/spark/pull/16572 cc @hvanhovell. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16572: [SPARK-18863][SQL] Output non-aggregate expressions with...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16572 **[Test build #71314 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71314/testReport)** for PR 16572 at commit [`24397cf`](https://github.com/apache/spark/commit/24397cf6c8728b4dfff22da14dc909dbb3b0a4e5). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16572: [SPARK-18863][SQL] Output non-aggregate expressions with...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16572 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16572: [SPARK-18863][SQL] Output non-aggregate expressions with...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16572 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71314/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16572: [SPARK-18863][SQL] Output non-aggregate expressions with...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16572 **[Test build #71314 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71314/testReport)** for PR 16572 at commit [`24397cf`](https://github.com/apache/spark/commit/24397cf6c8728b4dfff22da14dc909dbb3b0a4e5). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
