[GitHub] spark issue #16830: [MINOR][CORE] Fix incorrect documentation of WritableCon...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16830 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16830: [MINOR][CORE] Fix incorrect documentation of WritableCon...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16830 **[Test build #3569 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3569/testReport)** for PR 16830 at commit [`c300ff6`](https://github.com/apache/spark/commit/c300ff6e0a2d802c474b2af5e1bea9afb8101a2c). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16830: [MINOR][CORE] Fix incorrect documentation of WritableCon...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16830 **[Test build #3569 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3569/testReport)** for PR 16830 at commit [`c300ff6`](https://github.com/apache/spark/commit/c300ff6e0a2d802c474b2af5e1bea9afb8101a2c). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16830: [MINOR][CORE] Fix incorrect documentation of WritableCon...
Github user dongjinleekr commented on the issue: https://github.com/apache/spark/pull/16830 Is this exactly corresponds to your intention? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16830: [MINOR][CORE] Fix incorrect documentation of WritableCon...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16830 I don't quite understand the sentence -- it now talks about "T to Writable"? The change should be one word, and if you would, also improve the formatting with some back-ticks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16830: [MINOR][CORE] Fix incorrect documentation of WritableCon...
Github user dongjinleekr commented on the issue: https://github.com/apache/spark/pull/16830 Updated with the problem description. Please have a look when you are free. I will review the other documentation descriptions ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16830: [MINOR][CORE] Fix incorrect documentation of WritableCon...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16830 You're right about "to" vs "from" but why the word 'restoration'? 'conversion' remains correct. If you would, have a look at improving this and other docs around it while you're here. For example you could improve formatting by back-tick-quoting types. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16830: [MINOR][CORE] Fix incorrect documentation of WritableCon...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16830 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
