[GitHub] spark issue #16997: Updated the SQL programming guide to explain about the E...

2017-02-21 Thread HyukjinKwon 
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/16997
  
Could you fix the PR title too while you are online maybe? It might be nice 
to have a good title for both a commit log and those who like to track down the 
history.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #16997: Updated the SQL programming guide to explain about the E...

2017-02-21 Thread HarshSharma8 
Github user HarshSharma8 commented on the issue:

https://github.com/apache/spark/pull/16997
  
I updated the content with a demo object. I would appreciate if anyone can 
have a look at this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #16997: Updated the SQL programming guide to explain about the E...

2017-02-20 Thread srowen 
Github user srowen commented on the issue:

https://github.com/apache/spark/pull/16997
  
You are still bold-facing code elements, and now back-ticked a string, 
which isn't code. There are still typos like "create dataset" instead of 
"create a Dataset". Do you mean to write something to indicate a class name 
will be in the message? then write something like "[class name]". There is no 
object name here. Please review carefully before you ask for another review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #16997: Updated the SQL programming guide to explain about the E...

2017-02-20 Thread HarshSharma8 
Github user HarshSharma8 commented on the issue:

https://github.com/apache/spark/pull/16997
  
Hello Sean,
I have updated the content with back-ticks, Can you have a look at this ?
And i am not getting which object-name you are asking about.


Thank You


Best Regards |
*Harsh Sharma*
Sr. Software Consultant
Facebook  | Twitter
 | Linked In

harshs...@gmail.com
Skype*: khandal60*
*+91-8447307237*

On Tue, Feb 21, 2017 at 11:03 AM, Harsh Sharma  wrote:

> Hello Sean,
> I apologize for bold instead of back-ticks, and i'm updating the content
> for this.
>
>
> Thank You
>
>
> Best Regards |
> *Harsh Sharma*
> Sr. Software Consultant
> Facebook  | Twitter
>  | Linked In
> 
> harshs...@gmail.com
> Skype*: khandal60*
> *+91-8447307237*
>
> On Tue, Feb 21, 2017 at 10:58 AM, Sean Owen 
> wrote:
>
>> *@srowen* commented on this pull request.
>> --
>>
>> In docs/sql-programming-guide.md
>> :
>>
>> > @@ -297,6 +297,9 @@ reflection and become the names of the columns. 
Case classes can also be nested
>>  types such as `Seq`s or `Array`s. This RDD can be implicitly converted 
to a DataFrame and then be
>>  registered as a table. Tables can be used in subsequent SQL statements.
>>
>> +Spark Encoders are used to convert a JVM object to Spark SQL 
representation. To create dataset, spark requires an encoder which takes the 
form of Encoder[T] where T is the type which has to be encoded. 
Creation of a dataset with a custom type of object, may result into 
java.lang.UnsupportedOperationException: No Encoder found for 
Object-Name.
>>
>> Yes, @HarshSharma8  this still doesn't
>> address the comments. Use back-ticks for code, not bold, too. What is
>> Object-Name?
>>
>> —
>> You are receiving this because you were mentioned.
>> Reply to this email directly, view it on GitHub
>> , or 
mute
>> the thread
>> 

>> .
>>
>
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #16997: Updated the SQL programming guide to explain about the E...

2017-02-20 Thread HarshSharma8 
Github user HarshSharma8 commented on the issue:

https://github.com/apache/spark/pull/16997
  
Hello Sean,
I apologize for bold instead of back-ticks, and i'm updating the content
for this.


Thank You


Best Regards |
*Harsh Sharma*
Sr. Software Consultant
Facebook  | Twitter
 | Linked In

harshs...@gmail.com
Skype*: khandal60*
*+91-8447307237*

On Tue, Feb 21, 2017 at 10:58 AM, Sean Owen 
wrote:

> *@srowen* commented on this pull request.
> --
>
> In docs/sql-programming-guide.md
> :
>
> > @@ -297,6 +297,9 @@ reflection and become the names of the columns. 
Case classes can also be nested
>  types such as `Seq`s or `Array`s. This RDD can be implicitly converted 
to a DataFrame and then be
>  registered as a table. Tables can be used in subsequent SQL statements.
>
> +Spark Encoders are used to convert a JVM object to Spark SQL 
representation. To create dataset, spark requires an encoder which takes the 
form of Encoder[T] where T is the type which has to be encoded. 
Creation of a dataset with a custom type of object, may result into 
java.lang.UnsupportedOperationException: No Encoder found for 
Object-Name.
>
> Yes, @HarshSharma8  this still doesn't
> address the comments. Use back-ticks for code, not bold, too. What is
> Object-Name?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #16997: Updated the SQL programming guide to explain about the E...

2017-02-20 Thread HyukjinKwon 
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/16997
  
BTW, could we maybe make the title complete (not `opera…`)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #16997: Updated the SQL programming guide to explain about the E...

2017-02-19 Thread AmplabJenkins 
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/16997
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org