[GitHub] spark issue #17135: SPARK-19794 Release HDFS Client after read/write checkpo...
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/17135 It's not just a matter of performance regression - it will brake any other code that has references to the file system being closed. -1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17135: SPARK-19794 Release HDFS Client after read/write checkpo...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17135 Yes this is substantially not something we can merge, so let's close this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17135: SPARK-19794 Release HDFS Client after read/write checkpo...
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/17135 I remember FileSystem will be cached internally by default. Closing it probably will introduce some performance regression. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17135: SPARK-19794 Release HDFS Client after read/write checkpo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17135 **[Test build #3592 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3592/testReport)** for PR 17135 at commit [`60754bd`](https://github.com/apache/spark/commit/60754bd65a389181f055882daa390e8aea4e3989). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17135: SPARK-19794 Release HDFS Client after read/write checkpo...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17135 I get the idea, but I'm not sure any of these are valid --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17135: SPARK-19794 Release HDFS Client after read/write checkpo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17135 **[Test build #3592 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3592/testReport)** for PR 17135 at commit [`60754bd`](https://github.com/apache/spark/commit/60754bd65a389181f055882daa390e8aea4e3989). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17135: SPARK-19794 Release HDFS Client after read/write checkpo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17135 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
