[GitHub] spark issue #17136: [SPARK-19783][SQL] Treat shorter/longer lengths of token...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17136 **[Test build #73929 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73929/testReport)** for PR 17136 at commit [`4ece983`](https://github.com/apache/spark/commit/4ece98317aace65454e3e7fdc0317d564b572230). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17136: [SPARK-19783][SQL] Treat shorter/longer lengths of token...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17136 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73836/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17136: [SPARK-19783][SQL] Treat shorter/longer lengths of token...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17136 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17136: [SPARK-19783][SQL] Treat shorter/longer lengths of token...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17136 **[Test build #73836 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73836/testReport)** for PR 17136 at commit [`d88a966`](https://github.com/apache/spark/commit/d88a96684f50ad8674d0f1c6ad4a5f68faf271b4). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17136: [SPARK-19783][SQL] Treat shorter/longer lengths of token...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17136 **[Test build #73836 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73836/testReport)** for PR 17136 at commit [`d88a966`](https://github.com/apache/spark/commit/d88a96684f50ad8674d0f1c6ad4a5f68faf271b4). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17136: [SPARK-19783][SQL] Treat shorter/longer lengths of token...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17136 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73816/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17136: [SPARK-19783][SQL] Treat shorter/longer lengths of token...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17136 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17136: [SPARK-19783][SQL] Treat shorter/longer lengths of token...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17136 **[Test build #73816 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73816/testReport)** for PR 17136 at commit [`5a01a9d`](https://github.com/apache/spark/commit/5a01a9dcbe1fb922a7e240fdee3bd4b7fa4e471a). * This patch **fails SparkR unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17136: [SPARK-19783][SQL] Treat shorter/longer lengths of token...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17136 **[Test build #73816 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73816/testReport)** for PR 17136 at commit [`5a01a9d`](https://github.com/apache/spark/commit/5a01a9dcbe1fb922a7e240fdee3bd4b7fa4e471a). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17136: [SPARK-19783][SQL] Treat shorter/longer lengths of token...
Github user maropu commented on the issue: https://github.com/apache/spark/pull/17136 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17136: [SPARK-19783][SQL] Treat shorter/longer lengths of token...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17136 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17136: [SPARK-19783][SQL] Treat shorter/longer lengths of token...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17136 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73768/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17136: [SPARK-19783][SQL] Treat shorter/longer lengths of token...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17136 **[Test build #73768 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73768/testReport)** for PR 17136 at commit [`5a01a9d`](https://github.com/apache/spark/commit/5a01a9dcbe1fb922a7e240fdee3bd4b7fa4e471a). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17136: [SPARK-19783][SQL] Treat shorter/longer lengths of token...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17136 **[Test build #73768 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73768/testReport)** for PR 17136 at commit [`5a01a9d`](https://github.com/apache/spark/commit/5a01a9dcbe1fb922a7e240fdee3bd4b7fa4e471a). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17136: [SPARK-19783][SQL] Treat shorter/longer lengths of token...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17136 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73763/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17136: [SPARK-19783][SQL] Treat shorter/longer lengths of token...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17136 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17136: [SPARK-19783][SQL] Treat shorter/longer lengths of token...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17136 **[Test build #73763 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73763/testReport)** for PR 17136 at commit [`aa290ee`](https://github.com/apache/spark/commit/aa290ee32ef09d6d018f261c3bccb85d08259ac5). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17136: [SPARK-19783][SQL] Treat shorter/longer lengths of token...
Github user maropu commented on the issue: https://github.com/apache/spark/pull/17136 Aha, I see. Yes, some arguable about shorter lengths of tokens though, I think we need treat *longer* length of tokens as malformed ones because dropping some tokens leads to loss of information. Thought? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17136: [SPARK-19783][SQL] Treat shorter/longer lengths of token...
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17136
Oh, @maropu, I have been looking into R's `read.csv` before adding some
comments in the JIRAs.
with the data below:
```
a,b,c
a,b,c,d,e,d,d
```
```
> read.csv("test.csv")
Error in read.table(file = file, header = header, sep = sep, quote = quote,
:
```
with the data below:
```csv
a,b,c,d,e,d,d
a,b,c
```
```r
> read.csv("test.csv")
a b c d e d.1 d.2
1 a b c NA NA NA NA
```
So, IMHO, we might better follow R's `read.csv` for now but of course I
guess we should take a look for other libraries.
I am actually a bit worried of behaviour change because `PERMISSIVE` has
been the default mode and since it was as the thirdparty library (Spark 1.3+).
Another concern is, it seems we should produce `columnNameOfCorruptRecord`
as we are doing in JSON datasource if we will treat those tokens as malformed
ones in `PERMISSIVE` mode.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17136: [SPARK-19783][SQL] Treat shorter/longer lengths of token...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17136 **[Test build #73763 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73763/testReport)** for PR 17136 at commit [`aa290ee`](https://github.com/apache/spark/commit/aa290ee32ef09d6d018f261c3bccb85d08259ac5). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
