[GitHub] spark issue #17140: [SPARK-19796][CORE] Fix serialization of long property v...
Github user kayousterhout commented on the issue: https://github.com/apache/spark/pull/17140 @squito sounds good. Thanks for fixing this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17140: [SPARK-19796][CORE] Fix serialization of long property v...
Github user squito commented on the issue: https://github.com/apache/spark/pull/17140 @kayousterhout > Do you think we should do the same thing for properties keys? I think probably not? yeah I went back and forth on it, thinking maybe I should do the keys as well for consistency, but I think I'd rather we just have a hard failure for super long keys. I guess that could technically break something, but seems like a misuse ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17140: [SPARK-19796][CORE] Fix serialization of long property v...
Github user squito commented on the issue: https://github.com/apache/spark/pull/17140 merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17140: [SPARK-19796][CORE] Fix serialization of long property v...
Github user kayousterhout commented on the issue: https://github.com/apache/spark/pull/17140 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17140: [SPARK-19796][CORE] Fix serialization of long property v...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17140 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73802/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17140: [SPARK-19796][CORE] Fix serialization of long property v...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17140 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17140: [SPARK-19796][CORE] Fix serialization of long property v...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17140 **[Test build #73802 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73802/testReport)** for PR 17140 at commit [`99692bf`](https://github.com/apache/spark/commit/99692bf9860f375eab7f7c35d17f83d2c726ae77). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17140: [SPARK-19796][CORE] Fix serialization of long property v...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17140 **[Test build #73802 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73802/testReport)** for PR 17140 at commit [`99692bf`](https://github.com/apache/spark/commit/99692bf9860f375eab7f7c35d17f83d2c726ae77). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17140: [SPARK-19796][CORE] Fix serialization of long property v...
Github user mridulm commented on the issue: https://github.com/apache/spark/pull/17140 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17140: [SPARK-19796][CORE] Fix serialization of long property v...
Github user jsoltren commented on the issue: https://github.com/apache/spark/pull/17140 This seems like a reasonable approach to me, so long as writing the length of the string out doesn't break anything else (it doesn't appear to). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17140: [SPARK-19796][CORE] Fix serialization of long property v...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17140 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73777/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17140: [SPARK-19796][CORE] Fix serialization of long property v...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17140 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17140: [SPARK-19796][CORE] Fix serialization of long property v...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17140 **[Test build #73777 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73777/testReport)** for PR 17140 at commit [`60220a9`](https://github.com/apache/spark/commit/60220a9b4721b131aefaa4f34d175b46e6b65bc6). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17140: [SPARK-19796][CORE] Fix serialization of long property v...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17140 **[Test build #73777 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73777/testReport)** for PR 17140 at commit [`60220a9`](https://github.com/apache/spark/commit/60220a9b4721b131aefaa4f34d175b46e6b65bc6). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
