[GitHub] spark issue #17164: [SPARK-16844][SQL] Support codegen for sort-based aggrea...
Github user maropu commented on the issue: https://github.com/apache/spark/pull/17164 ok --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17164: [SPARK-16844][SQL] Support codegen for sort-based aggrea...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17164 @maropu Maybe we can close this PR at first? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17164: [SPARK-16844][SQL] Support codegen for sort-based aggrea...
Github user maropu commented on the issue: https://github.com/apache/spark/pull/17164 okay, I keep this open. Yea, sure and I'm interested in. If there are sub-tasks for that, I'd be grad if you ping me. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17164: [SPARK-16844][SQL] Support codegen for sort-based aggrea...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/17164 @maropu I am not sure. I like to keep interesting PRs open. Would you be interested in doing some work on the planner? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17164: [SPARK-16844][SQL] Support codegen for sort-based aggrea...
Github user maropu commented on the issue: https://github.com/apache/spark/pull/17164 okay, it'd be better to close this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17164: [SPARK-16844][SQL] Support codegen for sort-based aggrea...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/17164 @maropu I do think this is useful. However we really need to refactor the planner, if we want to get the most value from this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17164: [SPARK-16844][SQL] Support codegen for sort-based aggrea...
Github user maropu commented on the issue: https://github.com/apache/spark/pull/17164 @hvanhovell ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17164: [SPARK-16844][SQL] Support codegen for sort-based aggrea...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17164 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17164: [SPARK-16844][SQL] Support codegen for sort-based aggrea...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17164 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74569/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17164: [SPARK-16844][SQL] Support codegen for sort-based aggrea...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17164 **[Test build #74569 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74569/testReport)** for PR 17164 at commit [`5baa928`](https://github.com/apache/spark/commit/5baa928d758eaf4c6711c4a8d67611995ca3af25). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `trait AggregateCodegenHelper ` * `abstract class AggregateExec extends UnaryExecNode ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17164: [SPARK-16844][SQL] Support codegen for sort-based aggrea...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17164 **[Test build #74569 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74569/testReport)** for PR 17164 at commit [`5baa928`](https://github.com/apache/spark/commit/5baa928d758eaf4c6711c4a8d67611995ca3af25). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17164: [SPARK-16844][SQL] Support codegen for sort-based aggrea...
Github user maropu commented on the issue: https://github.com/apache/spark/pull/17164 @hvanhovell ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17164: [SPARK-16844][SQL] Support codegen for sort-based aggrea...
Github user maropu commented on the issue: https://github.com/apache/spark/pull/17164 @hvanhovell ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17164: [SPARK-16844][SQL] Support codegen for sort-based aggrea...
Github user maropu commented on the issue: https://github.com/apache/spark/pull/17164 A benchmark result: https://github.com/apache/spark/pull/17164/files#diff-b7bf86a20a79d572f81093300568db6eR44 ``` /* range/limit/sum: Best/Avg Time(ms)Rate(M/s) Per Row(ns) Relative -- range/limit/sum wholestage off 617 / 617 13.6 73.5 1.0X range/limit/sum wholestage on 70 / 92120.2 8.3 8.8X */ /* aggregate non-sorted data: Best/Avg Time(ms) Rate(M/s) Per Row(ns) Relative -- non-sorted data wholestage off2540 / 2735 3.3 302.8 1.0X non-sorted data wholestage on 1226 / 1528 6.8 146.1 2.1X */ /* aggregate cached and sorted data: Best/Avg Time(ms)Rate(M/s) Per Row(ns) Relative -- cached and sorted data wholestage off 1455 / 1586 5.8 173.4 1.0X cached and sorted data wholestage on 663 / 767 12.7 79.0 2.2X */ ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17164: [SPARK-16844][SQL] Support codegen for sort-based aggrea...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17164 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73907/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17164: [SPARK-16844][SQL] Support codegen for sort-based aggrea...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17164 **[Test build #73907 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73907/testReport)** for PR 17164 at commit [`f2ccc65`](https://github.com/apache/spark/commit/f2ccc6594172d2a3a9e9a1262879e75948ddb8c6). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `abstract class AggregateExec extends UnaryExecNode ` * `trait CodegenAggregateSupport extends CodegenSupport ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17164: [SPARK-16844][SQL] Support codegen for sort-based aggrea...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17164 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17164: [SPARK-16844][SQL] Support codegen for sort-based aggrea...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17164 **[Test build #73907 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73907/testReport)** for PR 17164 at commit [`f2ccc65`](https://github.com/apache/spark/commit/f2ccc6594172d2a3a9e9a1262879e75948ddb8c6). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
