[GitHub] spark issue #17178: [SPARK-19828][R] Support array type in from_json in R
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17178 thanks! merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17178: [SPARK-19828][R] Support array type in from_json in R
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17178 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74559/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17178: [SPARK-19828][R] Support array type in from_json in R
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17178 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17178: [SPARK-19828][R] Support array type in from_json in R
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17178 **[Test build #74559 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74559/testReport)** for PR 17178 at commit [`8ec7cd0`](https://github.com/apache/spark/commit/8ec7cd07e80b200397c96b2e8dff98267d118f1b). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17178: [SPARK-19828][R] Support array type in from_json in R
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17178 **[Test build #74559 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74559/testReport)** for PR 17178 at commit [`8ec7cd0`](https://github.com/apache/spark/commit/8ec7cd07e80b200397c96b2e8dff98267d118f1b). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17178: [SPARK-19828][R] Support array type in from_json in R
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17178 that's ridiculous ... dot in names is the norm https://stat.ethz.ch/R-manual/R-devel/library/utils/html/read.table.html anyway --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17178: [SPARK-19828][R] Support array type in from_json in R
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17178 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17178: [SPARK-19828][R] Support array type in from_json in R
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17178 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74507/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17178: [SPARK-19828][R] Support array type in from_json in R
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17178 **[Test build #74507 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74507/testReport)** for PR 17178 at commit [`d01f952`](https://github.com/apache/spark/commit/d01f952fcfd564cbf0643f5f4592cd8b4d52f4d7). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17178: [SPARK-19828][R] Support array type in from_json in R
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17178 **[Test build #74507 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74507/testReport)** for PR 17178 at commit [`d01f952`](https://github.com/apache/spark/commit/d01f952fcfd564cbf0643f5f4592cd8b4d52f4d7). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17178: [SPARK-19828][R] Support array type in from_json in R
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17178 Let me go for `as.json.object`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17178: [SPARK-19828][R] Support array type in from_json in R
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17178 seems like `object` is the right term in JSON lango - how about `as.json.object`? otherwise `as.json.array` (the opposite) or `as.json.object.array` might be good option --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17178: [SPARK-19828][R] Support array type in from_json in R
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17178 How about `as.struct`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17178: [SPARK-19828][R] Support array type in from_json in R
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17178 > array might be a bit vague - does that require the column value to be a JSON array, or just multiple JSON object spanning multiple line? Yup, it requires that input is a JSON array (multiple line case should be already fine regardless of this option). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17178: [SPARK-19828][R] Support array type in from_json in R
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17178 Thank you @felixcheung. Let me try to handle the comments soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17178: [SPARK-19828][R] Support array type in from_json in R
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/17178
a couple of thoughts
- a default FALSE parameter might be less intuitive - do you think we could
come up with a default TRUE parameter (ok, `single`?)
- if it's asX, typically it would be more R-like to name it `as.X`, eg.
`as.array`
- array might be a bit vague - does that require the column value to be a
JSON array, or just multiple JSON object spanning multiple line?
```
[
{
"title": "1",
edition: 3,
year: 2011
},
{
"title": "2",
edition: 2,
year: 2009
}
]
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17178: [SPARK-19828][R] Support array type in from_json in R
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17178 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17178: [SPARK-19828][R] Support array type in from_json in R
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17178 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74326/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17178: [SPARK-19828][R] Support array type in from_json in R
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17178 **[Test build #74326 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74326/testReport)** for PR 17178 at commit [`5c2450d`](https://github.com/apache/spark/commit/5c2450d0fbe1345df0472714dd3155a12db303a1). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17178: [SPARK-19828][R] Support array type in from_json in R
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17178 @felixcheung, I tried to add an optional parameter, `asArray`. Could you take a look and see if it makes sense? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17178: [SPARK-19828][R] Support array type in from_json in R
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17178 **[Test build #74326 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74326/testReport)** for PR 17178 at commit [`5c2450d`](https://github.com/apache/spark/commit/5c2450d0fbe1345df0472714dd3155a12db303a1). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17178: [SPARK-19828][R] Support array type in from_json in R
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17178 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17178: [SPARK-19828][R] Support array type in from_json in R
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17178 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73997/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17178: [SPARK-19828][R] Support array type in from_json in R
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17178 **[Test build #73997 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73997/testReport)** for PR 17178 at commit [`10feb9d`](https://github.com/apache/spark/commit/10feb9d2e9e4d027f874e6f508e7e7421c95cd6d). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17178: [SPARK-19828][R] Support array type in from_json in R
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17178 **[Test build #73997 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73997/testReport)** for PR 17178 at commit [`10feb9d`](https://github.com/apache/spark/commit/10feb9d2e9e4d027f874e6f508e7e7421c95cd6d). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17178: [SPARK-19828][R] Support array type in from_json in R
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17178 @felixcheung, this is a bit different with what we talked but I opened this because I thought you might like this more. This takes the type string given to `structField` now. If you are worried of this, let me change it back to the optional parameter one. Could you check if this makes sense to you? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
