[GitHub] spark issue #17401: [SPARK-18364][YARN] Expose metrics for YarnShuffleServic...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17401 gentle ping @ash211. I just wonder if it is active now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17401: [SPARK-18364][YARN] Expose metrics for YarnShuffleServic...
Github user ash211 commented on the issue: https://github.com/apache/spark/pull/17401 @jerryshao ready for re-review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17401: [SPARK-18364][YARN] Expose metrics for YarnShuffleServic...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17401 **[Test build #75322 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75322/testReport)** for PR 17401 at commit [`7c7d6d4`](https://github.com/apache/spark/commit/7c7d6d4c4c6f572e6e1646ff0b8e6e99e95b43c3). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17401: [SPARK-18364][YARN] Expose metrics for YarnShuffleServic...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17401 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75322/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17401: [SPARK-18364][YARN] Expose metrics for YarnShuffleServic...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17401 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17401: [SPARK-18364][YARN] Expose metrics for YarnShuffleServic...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17401 **[Test build #75322 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75322/testReport)** for PR 17401 at commit [`7c7d6d4`](https://github.com/apache/spark/commit/7c7d6d4c4c6f572e6e1646ff0b8e6e99e95b43c3). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17401: [SPARK-18364][YARN] Expose metrics for YarnShuffleServic...
Github user ash211 commented on the issue: https://github.com/apache/spark/pull/17401 Ready for further review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17401: [SPARK-18364][YARN] Expose metrics for YarnShuffleServic...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17401 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17401: [SPARK-18364][YARN] Expose metrics for YarnShuffleServic...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17401 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75165/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17401: [SPARK-18364][YARN] Expose metrics for YarnShuffleServic...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17401 **[Test build #75165 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75165/testReport)** for PR 17401 at commit [`96a0882`](https://github.com/apache/spark/commit/96a0882843e9072bb2ef02ee798a6e5d2f0a41b0). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17401: [SPARK-18364][YARN] Expose metrics for YarnShuffleServic...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17401 **[Test build #75165 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75165/testReport)** for PR 17401 at commit [`96a0882`](https://github.com/apache/spark/commit/96a0882843e9072bb2ef02ee798a6e5d2f0a41b0). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17401: [SPARK-18364][YARN] Expose metrics for YarnShuffleServic...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17401 **[Test build #75157 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75157/testReport)** for PR 17401 at commit [`9992c10`](https://github.com/apache/spark/commit/9992c10ccb2f38a7089ac21c31d3adaf23c9a2ba). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17401: [SPARK-18364][YARN] Expose metrics for YarnShuffleServic...
Github user ash211 commented on the issue: https://github.com/apache/spark/pull/17401 Thanks again for the comments @jerryshao ! I've now added some tests to verify that the metrics get converted in the expected way to the collector, and camel-cased shuffleService --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17401: [SPARK-18364][YARN] Expose metrics for YarnShuffleServic...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17401 **[Test build #75157 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75157/testReport)** for PR 17401 at commit [`9992c10`](https://github.com/apache/spark/commit/9992c10ccb2f38a7089ac21c31d3adaf23c9a2ba). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17401: [SPARK-18364][YARN] Expose metrics for YarnShuffleServic...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17401 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75157/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17401: [SPARK-18364][YARN] Expose metrics for YarnShuffleServic...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17401 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17401: [SPARK-18364][YARN] Expose metrics for YarnShuffleServic...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17401 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75150/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17401: [SPARK-18364][YARN] Expose metrics for YarnShuffleServic...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17401 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17401: [SPARK-18364][YARN] Expose metrics for YarnShuffleServic...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17401 **[Test build #75150 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75150/testReport)** for PR 17401 at commit [`13aa4ff`](https://github.com/apache/spark/commit/13aa4ff86038d706e7f3c3dfff449c6e762205f3). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17401: [SPARK-18364][YARN] Expose metrics for YarnShuffleServic...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17401 **[Test build #75150 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75150/testReport)** for PR 17401 at commit [`13aa4ff`](https://github.com/apache/spark/commit/13aa4ff86038d706e7f3c3dfff449c6e762205f3). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17401: [SPARK-18364][YARN] Expose metrics for YarnShuffleServic...
Github user ash211 commented on the issue: https://github.com/apache/spark/pull/17401 Thanks for taking a look @jerryshao ! I've reformatted to two-space indentation and run `./dev/lint-java` to make sure this code passes the linter. `src/main/java/org/apache/spark/sql/streaming/GroupStateTimeout.java` still has some errors but those are separate from this change --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17401: [SPARK-18364][YARN] Expose metrics for YarnShuffleServic...
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/17401 Actually we follow two space indent for java code in Spark, would you please change the format? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17401: [SPARK-18364][YARN] Expose metrics for YarnShuffleServic...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17401 **[Test build #75115 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75115/testReport)** for PR 17401 at commit [`4caf4d2`](https://github.com/apache/spark/commit/4caf4d28819d82240f1d61e11cdabd68fafad14a). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `public class YarnShuffleServiceMetrics implements MetricsSource ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17401: [SPARK-18364][YARN] Expose metrics for YarnShuffleServic...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17401 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17401: [SPARK-18364][YARN] Expose metrics for YarnShuffleServic...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17401 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75115/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17401: [SPARK-18364][YARN] Expose metrics for YarnShuffleServic...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17401 **[Test build #75115 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75115/testReport)** for PR 17401 at commit [`4caf4d2`](https://github.com/apache/spark/commit/4caf4d28819d82240f1d61e11cdabd68fafad14a). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
