[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[rxin]

Github user rxin commented on the issue:

https://github.com/apache/spark/pull/17487
  
Merging in master.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[samelamin]

Github user samelamin commented on the issue:

https://github.com/apache/spark/pull/17487
  
perfect! Can it be merged then? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[cloud-fan]

Github user cloud-fan commented on the issue:

https://github.com/apache/spark/pull/17487
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[gatorsmile]

Github user gatorsmile commented on the issue:

https://github.com/apache/spark/pull/17487
  
LGTM cc @hvanhovell @cloud-fan 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/17487
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/17487
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75481/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/17487
  
**[Test build #75481 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75481/testReport)**
 for PR 17487 at commit 
[`406eba8`](https://github.com/apache/spark/commit/406eba8f2e0e5cf1d6a349a1a3f6c35e99ed6f15).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/17487
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/17487
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75480/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/17487
  
**[Test build #75480 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75480/testReport)**
 for PR 17487 at commit 
[`a01aba6`](https://github.com/apache/spark/commit/a01aba6d5646be61b047d312aca2a4b27887db2d).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds the following public classes _(experimental)_:
  * `case class UnresolvedTableValuedFunction(functionName: String, 
functionArgs: Seq[Expression])`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/17487
  
**[Test build #75481 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75481/testReport)**
 for PR 17487 at commit 
[`406eba8`](https://github.com/apache/spark/commit/406eba8f2e0e5cf1d6a349a1a3f6c35e99ed6f15).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/17487
  
**[Test build #75480 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75480/testReport)**
 for PR 17487 at commit 
[`a01aba6`](https://github.com/apache/spark/commit/a01aba6d5646be61b047d312aca2a4b27887db2d).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[selamin]

Github user selamin commented on the issue:

https://github.com/apache/spark/pull/17487
  
@gatorsmile thanks so much for that, i spent over 2 hours getting that sql 
file correct manually! what was frustrating was after all that i had to revert 
my changes 😢 

Atleast I know this now so it wasnt a complete waste! Anyways I updated the 
code to remove the vars


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[gatorsmile]

Github user gatorsmile commented on the issue:

https://github.com/apache/spark/pull/17487
  
See the [code 
changes](https://github.com/apache/spark/commit/d9c24b3dc5ca64cf8aecebf58f22a3a2e5aab821)
 I made in my private branch. 

To generate the new result file after you add the new queries into the 
`.sql` files, you need to run the following command. 
```
SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/test-only *SQLQueryTestSuite"
```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/17487
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/17487
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75463/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/17487
  
**[Test build #75463 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75463/testReport)**
 for PR 17487 at commit 
[`6efb254`](https://github.com/apache/spark/commit/6efb25482ace898beeb94fca2a358f49650ebadb).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/17487
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75462/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/17487
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/17487
  
**[Test build #75462 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75462/testReport)**
 for PR 17487 at commit 
[`8bce1da`](https://github.com/apache/spark/commit/8bce1da346294a7aec405ca6eb9c59474f0880a3).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds the following public classes _(experimental)_:
  * `case class UnresolvedTableValuedFunction(var functionName: String, 
functionArgs: Seq[Expression])`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[samelamin]

Github user samelamin commented on the issue:

https://github.com/apache/spark/pull/17487
  
FYI I can squash these commits to clean up the history once we agree on how 
best to approach the testing 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/17487
  
**[Test build #75463 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75463/testReport)**
 for PR 17487 at commit 
[`6efb254`](https://github.com/apache/spark/commit/6efb25482ace898beeb94fca2a358f49650ebadb).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/17487
  
**[Test build #75462 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75462/testReport)**
 for PR 17487 at commit 
[`8bce1da`](https://github.com/apache/spark/commit/8bce1da346294a7aec405ca6eb9c59474f0880a3).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[samelamin]

Github user samelamin commented on the issue:

https://github.com/apache/spark/pull/17487
  
Maybe @gatorsmile or @srowen have an idea. How can I test the case 
insensitive unresolvedTableValuedFunction without using a var for the 
functionName. I'm open to all ideas folks! introducing a var just for the tests 
feels inheritely incorrect. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/17487
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/17487
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75460/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/17487
  
**[Test build #75460 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75460/testReport)**
 for PR 17487 at commit 
[`ccbfcb3`](https://github.com/apache/spark/commit/ccbfcb32c1e5ccf83c3aea473e309ec1a9b9fbf9).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[samelamin]

Github user samelamin commented on the issue:

https://github.com/apache/spark/pull/17487
  
Ok I was planning on doing that but unfortunately all the tests don't go 
through the resolveTableValuedFuntion but new up an UnTableValued. I totally 
agree with you with regards to state. What we can do is create a method that 
calculates the function name inside the unresolvedTableValuedFunction which 
then has the dependency on the conf. How does that sound?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/17487
  
**[Test build #75460 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75460/testReport)**
 for PR 17487 at commit 
[`ccbfcb3`](https://github.com/apache/spark/commit/ccbfcb32c1e5ccf83c3aea473e309ec1a9b9fbf9).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/17487
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/17487
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75453/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/17487
  
**[Test build #75453 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75453/testReport)**
 for PR 17487 at commit 
[`407bdbf`](https://github.com/apache/spark/commit/407bdbf1ae66b73d47611477b9ce0f03dc37ff7b).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds the following public classes _(experimental)_:
  * `case class UnresolvedTableValuedFunction(conf: SQLConf,`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[samelamin]

Github user samelamin commented on the issue:

https://github.com/apache/spark/pull/17487
  
based on comments from @hvanhovell  I am depending on the case sensitivity 
setting of the analyser. That said I had to make the functionName a var to 
change the value to lower case which feels like a code smell to me. I am happy 
with suggestions to how I can improve on it



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/17487
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/17487
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75426/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/17487
  
**[Test build #75426 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75426/testReport)**
 for PR 17487 at commit 
[`ee15dc0`](https://github.com/apache/spark/commit/ee15dc0bed3818b11321b8dd60c5e0499964d343).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/17487
  
**[Test build #75426 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75426/testReport)**
 for PR 17487 at commit 
[`ee15dc0`](https://github.com/apache/spark/commit/ee15dc0bed3818b11321b8dd60c5e0499964d343).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[samelamin]

Github user samelamin commented on the issue:

https://github.com/apache/spark/pull/17487
  
I'm not sure to be honest. But even if it is, the inbuilt functions has a
key of "range"

So anything else won't be found which is causing the problem in the first
place


On Thu, 30 Mar 2017 at 23:26, Xiao Li  wrote:

*@gatorsmile* commented on this pull request.
--

In

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedFunctions.scala
:

> @@ -105,7 +105,7 @@ object ResolveTableValuedFunctions extends 
Rule[LogicalPlan] {

   override def apply(plan: LogicalPlan): LogicalPlan = plan 
resolveOperators {
 case u: UnresolvedTableValuedFunction if
u.functionArgs.forall(_.resolved) =>
-  builtinFunctions.get(u.functionName) match {
+  builtinFunctions.get(u.functionName.toLowerCase) match {

Does the function name is case sensitive in Hive?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
,
or mute
the thread


.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

[hvanhovell]

Github user hvanhovell commented on the issue:

https://github.com/apache/spark/pull/17487
  
ok to test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org