[GitHub] spark issue #17746: [SPARK-20449][ML] Upgrade breeze version to 0.13.1
Github user superbobry commented on the issue: https://github.com/apache/spark/pull/17746 Thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17746: [SPARK-20449][ML] Upgrade breeze version to 0.13.1
Github user dbtsai commented on the issue: https://github.com/apache/spark/pull/17746 @superbobry As you can see in this PR, one of them is ```scala -override def link(mu: Double): Double = dist.Gaussian(0.0, 1.0).icdf(mu) +override def link(mu: Double): Double = dist.Gaussian(0.0, 1.0).inverseCdf(mu) ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17746: [SPARK-20449][ML] Upgrade breeze version to 0.13.1
Github user superbobry commented on the issue: https://github.com/apache/spark/pull/17746 @srowen thanks! I've missed the point that 0.13.1 was intentionally merged into the upcoming release. @dbtsai could you give an example of the breaking API change between 0.12 and 0.13.1? I'm sure I've missed it as well, but from the commit log it seems it's all bug fixes or backward-compatible changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17746: [SPARK-20449][ML] Upgrade breeze version to 0.13.1
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17746 @superbobry see the discussion above? doesn't seem safe to do so --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17746: [SPARK-20449][ML] Upgrade breeze version to 0.13.1
Github user superbobry commented on the issue: https://github.com/apache/spark/pull/17746 Hello, are there any plans to backport this into 2.1 branch? The LBFGS and other fixex in 0.13.1 seem important enough. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17746: [SPARK-20449][ML] Upgrade breeze version to 0.13.1
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/17746 @dbtsai Thanks for the explanation and the context :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17746: [SPARK-20449][ML] Upgrade breeze version to 0.13.1
Github user dbtsai commented on the issue: https://github.com/apache/spark/pull/17746 The motivation to have this one merged in Spark 2.2 is not only just for #17715 but also because Breeze 0.13.x fixes many bugs in upstream. Since Spark was tightened to 0.12, many users (including my company) have difficulty to upgrade Breeze alone by themselves, which forces people to have a copy of implements with fixes in the application code. In the long term, because we only use Breeze's optimizer in Spark, we should have our optimizer implementation in mllib-local to remove the heavy external dependencies. In retrospect, we started to work on the fix we want to have in upstream too late, so we had the upstream to release the fixes right after the 2.2 branch was cut. We should definitely plan it earlier in the future. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17746: [SPARK-20449][ML] Upgrade breeze version to 0.13.1
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/17746 +10 for not merging major changes like this so close to the release, especially after an RC has been cut, unless it's for blocker bugs. Same for new APIs such as https://github.com/apache/spark/pull/17715 I guess it's OK not to revert them, but let's definitely avoid doing this in the future. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17746: [SPARK-20449][ML] Upgrade breeze version to 0.13.1
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/17746 Can I ask how we decided merging this dependency change after the cut of the release branch (especially this change affects user code)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17746: [SPARK-20449][ML] Upgrade breeze version to 0.13.1
Github user dbtsai commented on the issue: https://github.com/apache/spark/pull/17746 @srowen Couple APIs changes in Breeze 0.13 are not source code compatible with 0.12. We should tell users about that in the release note, and they need to do their migration if they are using Breeze in their application. FYI, we only use optimization package in Breeze now, and we have a plan to move the optimization code into Spark to reduce the 3rd party dependencies brought by Breeze. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17746: [SPARK-20449][ML] Upgrade breeze version to 0.13.1
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17746 Not that I have any specific concern, but did anyone look at the changes from 0.12 to 0.13 to see if anything might be breaking? probably not, but it does leak into the user classpath --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17746: [SPARK-20449][ML] Upgrade breeze version to 0.13.1
Github user dbtsai commented on the issue: https://github.com/apache/spark/pull/17746 Many thanks for @WeichenXu123 helping to fix this bug in breeze! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17746: [SPARK-20449][ML] Upgrade breeze version to 0.13.1
Github user dbtsai commented on the issue: https://github.com/apache/spark/pull/17746 LGTM. Merged into master and branch 2.2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17746: [SPARK-20449][ML] Upgrade breeze version to 0.13.1
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17746 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76110/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17746: [SPARK-20449][ML] Upgrade breeze version to 0.13.1
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17746 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17746: [SPARK-20449][ML] Upgrade breeze version to 0.13.1
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17746 **[Test build #76110 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76110/testReport)** for PR 17746 at commit [`aeb7eb5`](https://github.com/apache/spark/commit/aeb7eb588fa7779cf64e51fcfa083056e3d8ccbf). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17746: [SPARK-20449][ML] Upgrade breeze version to 0.13.1
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/17746 cc @dbtsai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17746: [SPARK-20449][ML] Upgrade breeze version to 0.13.1
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17746 **[Test build #76110 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76110/testReport)** for PR 17746 at commit [`aeb7eb5`](https://github.com/apache/spark/commit/aeb7eb588fa7779cf64e51fcfa083056e3d8ccbf). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
