[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18113 @setjet, mind updating this please? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18113 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18113 **[Test build #91605 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91605/testReport)** for PR 18113 at commit [`ce6a7bf`](https://github.com/apache/spark/commit/ce6a7bfc9201e50ca10290e903e859890ef4fad4). * This patch **fails Java style tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18113 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91605/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18113 **[Test build #91605 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91605/testReport)** for PR 18113 at commit [`ce6a7bf`](https://github.com/apache/spark/commit/ce6a7bfc9201e50ca10290e903e859890ef4fad4). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18113 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18113 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18113 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18113 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18113 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18113 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84508/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18113 **[Test build #84508 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84508/testReport)** for PR 18113 at commit [`e37eec7`](https://github.com/apache/spark/commit/e37eec784584800668aa46cec09052f681edb167). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `trait TypedMaxDouble[IN, OUT] extends Aggregator[IN, MutableDouble, OUT] ` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18113 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18113 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84507/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18113 **[Test build #84507 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84507/testReport)** for PR 18113 at commit [`c197cb1`](https://github.com/apache/spark/commit/c197cb1a930db390979f9926562347802280d1ea). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `trait TypedMinDouble[IN, OUT] extends Aggregator[IN, MutableDouble, OUT] ` * `class JavaTypedMinDouble[IN](val f: IN => Double) extends TypedMinDouble[IN, java.lang.Double] ` * `class ScalaTypedMinDouble[IN](val f: IN => Double) extends TypedMinDouble[IN, Option[Double]] ` * `trait TypedMaxDouble[IN, OUT] extends Aggregator[IN, MutableDouble, OUT] ` * `class JavaTypedMaxDouble[IN](val f: IN => Double) extends TypedMaxDouble[IN, java.lang.Double] ` * `class ScalaTypedMaxDouble[IN](val f: IN => Double) extends TypedMaxDouble[IN, Option[Double]] ` * `trait TypedMinLong[IN, OUT] extends Aggregator[IN, MutableLong, OUT] ` * `class JavaTypedMinLong[IN](val f: IN => Long) extends TypedMinLong[IN, java.lang.Long] ` * `class ScalaTypedMinLong[IN](val f: IN => Long) extends TypedMinLong[IN, Option[Long]] ` * `trait TypedMaxLong[IN, OUT] extends Aggregator[IN, MutableLong, OUT] ` * `class JavaTypedMaxLong[IN](val f: IN => Long) extends TypedMaxLong[IN, java.lang.Long] ` * `class ScalaTypedMaxLong[IN](val f: IN => Long) extends TypedMaxLong[IN, Option[Long]] ` * `class MutableLong(var value: Long) extends Serializable` * `class MutableDouble(var value: Double) extends Serializable` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user setjet commented on the issue:
https://github.com/apache/spark/pull/18113
There is one issue however I am stuck on: the tests for empty sets ("typed
aggregate: empty") seem to be casting to nulls from options, resulting into the
following:
Decoded objects do not match expected objects:
expected: WrappedArray([0.0,0,NaN,None,None,None,None])
actual: WrappedArray([0.0,0,NaN,[null],[null],[null],[null]])
This doesn't happen to non-empty data sets. Does anyone have a clue?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18113 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84509/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18113 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18113 **[Test build #84509 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84509/testReport)** for PR 18113 at commit [`ce6a7bf`](https://github.com/apache/spark/commit/ce6a7bfc9201e50ca10290e903e859890ef4fad4). * This patch **fails to build**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18113 **[Test build #84509 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84509/testReport)** for PR 18113 at commit [`ce6a7bf`](https://github.com/apache/spark/commit/ce6a7bfc9201e50ca10290e903e859890ef4fad4). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18113 **[Test build #84508 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84508/testReport)** for PR 18113 at commit [`e37eec7`](https://github.com/apache/spark/commit/e37eec784584800668aa46cec09052f681edb167). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18113 **[Test build #84507 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84507/testReport)** for PR 18113 at commit [`c197cb1`](https://github.com/apache/spark/commit/c197cb1a930db390979f9926562347802280d1ea). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18113 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18113 **[Test build #84472 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84472/testReport)** for PR 18113 at commit [`20216e4`](https://github.com/apache/spark/commit/20216e4cda40b75b98152954d1055cf062f818f0). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class TypedMinDouble[IN](val f: IN => Double)` * `class TypedMaxDouble[IN](val f: IN => Double)` * `class TypedMinLong[IN](val f: IN => Long) extends Aggregator[IN, MutableLong, java.lang.Long] ` * `class TypedMaxLong[IN](val f: IN => Long) extends Aggregator[IN, MutableLong, java.lang.Long] ` * `class MutableLong(var value: Long) extends Serializable ` * `class MutableDouble(var value: Double) extends Serializable ` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18113 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84472/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18113 **[Test build #84472 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84472/testReport)** for PR 18113 at commit [`20216e4`](https://github.com/apache/spark/commit/20216e4cda40b75b98152954d1055cf062f818f0). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18113 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user setjet commented on the issue: https://github.com/apache/spark/pull/18113 @cloud-fan done, could you please have a look? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user setjet commented on the issue: https://github.com/apache/spark/pull/18113 @cloud-fan done, some small white spaces remain as it formats the functions within the file consistently --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18113 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18113 **[Test build #84175 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84175/testReport)** for PR 18113 at commit [`f4d62e9`](https://github.com/apache/spark/commit/f4d62e98730c9119fb08f9f0e4b41f8373ebf61a). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class TypedAverage[IN](val f: IN => Double) extends Aggregator[IN, (Double, Long), Double] ` * `class TypedMinDouble[IN](val f: IN => Double) extends Aggregator[IN, Double, Double] ` * `class TypedMaxDouble[IN](val f: IN => Double) extends Aggregator[IN, Double, Double] ` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18113 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84175/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18113 **[Test build #84175 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84175/testReport)** for PR 18113 at commit [`f4d62e9`](https://github.com/apache/spark/commit/f4d62e98730c9119fb08f9f0e4b41f8373ebf61a). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18113 can you check the diff and revert all the unnecessary changes? thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18113 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user setjet commented on the issue: https://github.com/apache/spark/pull/18113 @cloud-fan could you have a look please? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user setjet commented on the issue: https://github.com/apache/spark/pull/18113 Exactly my point. I'll return -/+ inf then for doubles only, and min/max values for longs --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18113 BTW let's not change the existing type sum, it already follows mathematical standard as we expected. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18113 doubles has -inf and +inf, can we use that? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user setjet commented on the issue: https://github.com/apache/spark/pull/18113 Ok sounds good. What about doubles? We could return the proper mathematical defintion, but that is not consistent with Longs --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18113 sounds good. I think the deal is, typed sum/count/max/min should follow mathematical standard instead of sql. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user setjet commented on the issue: https://github.com/apache/spark/pull/18113 An empty sets min and max are defined is -infinity and +infinity: https://en.wikipedia.org/wiki/Empty_set This is supported for Java doubles, but not for Longs. We could instead Long.MIN and Long.MAX values? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18113 So the existing typed sum follows the mathmatical standard, not sql standard. Do we have a mathmatical standard for empty max/min? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user setjet commented on the issue: https://github.com/apache/spark/pull/18113 @cloud-fan Sorry i misread the conclusion of the discussion, reverted the initial api to exactly how it was before, while the new functions follow the SQL standard as you agreed on 2 weeks ago. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user setjet commented on the issue: https://github.com/apache/spark/pull/18113 @gatorsmile @cloud-fan Could you have a look please? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user setjet commented on the issue: https://github.com/apache/spark/pull/18113 Hi, it has been a while but I can pick it back up when I have time next weekend or so if that's OK. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18113 @setjet Are you still working on this PR? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18113 It seems to me that the behavior of those aggregators on empty dataset might be different than `min`, `max`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18113 cc @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18113: [SPARK-20890][SQL] Added min and max typed aggregation f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18113 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
