[GitHub] spark issue #18400: [SPARK-21188][CORE] releaseAllLocksForTask should synchr...
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/18400 LGTM. Merging to master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18400: [SPARK-21188][CORE] releaseAllLocksForTask should synchr...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18400 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78909/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18400: [SPARK-21188][CORE] releaseAllLocksForTask should synchr...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18400 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18400: [SPARK-21188][CORE] releaseAllLocksForTask should synchr...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18400 **[Test build #78909 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78909/testReport)** for PR 18400 at commit [`5cdd328`](https://github.com/apache/spark/commit/5cdd328ee9a32969377cbdbfea229cc364dbee17). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18400: [SPARK-21188][CORE] releaseAllLocksForTask should synchr...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18400 **[Test build #78909 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78909/testReport)** for PR 18400 at commit [`5cdd328`](https://github.com/apache/spark/commit/5cdd328ee9a32969377cbdbfea229cc364dbee17). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18400: [SPARK-21188][CORE] releaseAllLocksForTask should synchr...
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/18400 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18400: [SPARK-21188][CORE] releaseAllLocksForTask should synchr...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18400 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78585/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18400: [SPARK-21188][CORE] releaseAllLocksForTask should synchr...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18400 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18400: [SPARK-21188][CORE] releaseAllLocksForTask should synchr...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18400 **[Test build #78585 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78585/testReport)** for PR 18400 at commit [`5cdd328`](https://github.com/apache/spark/commit/5cdd328ee9a32969377cbdbfea229cc364dbee17). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18400: [SPARK-21188][CORE] releaseAllLocksForTask should synchr...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18400 **[Test build #78585 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78585/testReport)** for PR 18400 at commit [`5cdd328`](https://github.com/apache/spark/commit/5cdd328ee9a32969377cbdbfea229cc364dbee17). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18400: [SPARK-21188][CORE] releaseAllLocksForTask should synchr...
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/18400 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18400: [SPARK-21188][CORE] releaseAllLocksForTask should synchr...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18400 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78571/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18400: [SPARK-21188][CORE] releaseAllLocksForTask should synchr...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18400 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18400: [SPARK-21188][CORE] releaseAllLocksForTask should synchr...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18400 **[Test build #78571 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78571/testReport)** for PR 18400 at commit [`5cdd328`](https://github.com/apache/spark/commit/5cdd328ee9a32969377cbdbfea229cc364dbee17). * This patch **fails PySpark pip packaging tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18400: [SPARK-21188][CORE] releaseAllLocksForTask should synchr...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18400 **[Test build #78571 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78571/testReport)** for PR 18400 at commit [`5cdd328`](https://github.com/apache/spark/commit/5cdd328ee9a32969377cbdbfea229cc364dbee17). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18400: [SPARK-21188][CORE] releaseAllLocksForTask should synchr...
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/18400 jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18400: [SPARK-21188][CORE] releaseAllLocksForTask should synchr...
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/18400 I actually asked @liufengdb to submit this PR after he spotted this problem while debugging a test. I did a bit of digging and spotted where this bug was introduced: in https://github.com/JoshRosen/spark/commit/b9d6e181db0c7293b0b00b3a679716f652df936f, an intermediate commit in an old PR, this was introduced when refactoring one map from a thread-safe LoadingCache (where entires were implicitly created) to an explicit map with explicit registration (which used synchronization). In making this change I incorrectly preserved a bad synchronization pattern which was unnecessarily fine-grained. Therefore this looks like the right change to me so I'm going to retest and merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18400: [SPARK-21188][CORE] releaseAllLocksForTask should synchr...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18400 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78555/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18400: [SPARK-21188][CORE] releaseAllLocksForTask should synchr...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18400 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18400: [SPARK-21188][CORE] releaseAllLocksForTask should synchr...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18400 **[Test build #78555 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78555/testReport)** for PR 18400 at commit [`5cdd328`](https://github.com/apache/spark/commit/5cdd328ee9a32969377cbdbfea229cc364dbee17). * This patch **fails PySpark pip packaging tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18400: [SPARK-21188][CORE] releaseAllLocksForTask should synchr...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18400 **[Test build #78555 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78555/testReport)** for PR 18400 at commit [`5cdd328`](https://github.com/apache/spark/commit/5cdd328ee9a32969377cbdbfea229cc364dbee17). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18400: [SPARK-21188][CORE] releaseAllLocksForTask should synchr...
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/18400 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18400: [SPARK-21188][CORE] releaseAllLocksForTask should synchr...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18400 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78539/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18400: [SPARK-21188][CORE] releaseAllLocksForTask should synchr...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18400 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18400: [SPARK-21188][CORE] releaseAllLocksForTask should synchr...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18400 **[Test build #78539 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78539/testReport)** for PR 18400 at commit [`5cdd328`](https://github.com/apache/spark/commit/5cdd328ee9a32969377cbdbfea229cc364dbee17). * This patch **fails PySpark pip packaging tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18400: [SPARK-21188][CORE] releaseAllLocksForTask should synchr...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18400 **[Test build #78539 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78539/testReport)** for PR 18400 at commit [`5cdd328`](https://github.com/apache/spark/commit/5cdd328ee9a32969377cbdbfea229cc364dbee17). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18400: [SPARK-21188][CORE] releaseAllLocksForTask should synchr...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18400 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18400: [SPARK-21188][CORE] releaseAllLocksForTask should synchr...
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/18400 ok to test. cc @JoshRosen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18400: [SPARK-21188][CORE] releaseAllLocksForTask should synchr...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18400 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
