[GitHub] spark issue #18414: [SPARK-21169] [core] Make sure to update application sta...

2017-06-26 Thread jerryshao
Github user jerryshao commented on the issue:

https://github.com/apache/spark/pull/18414
  
From my understanding, only when Master fully recovered, then `Master` 
could receive new application registering. In the recovering period, all the 
recovered applications have already ran, so changing the state of recovered app 
to "RUNNING" should be safe. Please correct me if I'm wrong.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18414: [SPARK-21169] [core] Make sure to update application sta...

2017-06-26 Thread srini-daruna
Github user srini-daruna commented on the issue:

https://github.com/apache/spark/pull/18414
  
@jerryshao Sorry, i have not used the code with SPARK-12552. I used older 
one and didn't check the fix. Do you think marking every one as RUNNING OK.? 
Because, applications may wait for resources sometimes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18414: [SPARK-21169] [core] Make sure to update application sta...

2017-06-25 Thread jerryshao
Github user jerryshao commented on the issue:

https://github.com/apache/spark/pull/18414
  
@srini-daruna I think I already addressed this issue in SPARK-12552, here 
is the 
[code](https://github.com/srini-daruna/spark/blob/b3ea3358a7bf55cedaa5cd7d08860bc625e83cd2/core/src/main/scala/org/apache/spark/deploy/master/Master.scala#L552).
 Did you test with SPARK-12552 in or not? Also is that fix not enough to 
address the problem?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org