[GitHub] spark issue #18539: [SPARK-21313][SS] ConsoleSink's string representation
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18539 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18539: [SPARK-21313][SS] ConsoleSink's string representation
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18539 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79281/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18539: [SPARK-21313][SS] ConsoleSink's string representation
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18539 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18539: [SPARK-21313][SS] ConsoleSink's string representation
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18539 **[Test build #79281 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79281/testReport)** for PR 18539 at commit [`3c8dc5a`](https://github.com/apache/spark/commit/3c8dc5a284935de1764f31e372e0ae55d33a32e6). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `case class AlterFunctionPreEvent(database: String, name: String) extends FunctionEvent` * `case class AlterFunctionEvent(database: String, name: String) extends FunctionEvent` * `class AstBuilder extends SqlBaseBaseVisitor[AnyRef] with Logging ` * `throw new AnalysisException(s\"UDF class $` * `throw new AnalysisException(s\"It is invalid to implement multiple UDF interfaces, UDF class $` * ` throw new AnalysisException(s\"UDF class with $` * `throw new AnalysisException(s\"Can not instantiate class $` * ` case e: ClassNotFoundException => throw new AnalysisException(s\"Can not load class $` * `throw new AnalysisException(s\"class $className doesn't implement interface UserDefinedAggregateFunction\")` * ` case e: ClassNotFoundException => throw new AnalysisException(s\"Can not load class $` * `throw new AnalysisException(s\"Can not instantiate class $` * `class SparkSqlParser extends AbstractSqlParser ` * `class SparkSqlAstBuilder extends AstBuilder ` * `class VariableSubstitution ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18539: [SPARK-21313][SS] ConsoleSink's string representation
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18539 **[Test build #79281 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79281/testReport)** for PR 18539 at commit [`3c8dc5a`](https://github.com/apache/spark/commit/3c8dc5a284935de1764f31e372e0ae55d33a32e6). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18539: [SPARK-21313][SS] ConsoleSink's string representation
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/18539 If you know how to display `ForeachWriter` that's passed in to `ForeachSink` nicely, let me know. `getClass.getName` didn't convince me and so I left it out. It'd be very helpful to see what the implementation is though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18539: [SPARK-21313][SS] ConsoleSink's string representation
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18539 Just happened to double check to help. Sounds we have the last one, `ForeachSink`, left. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18539: [SPARK-21313][SS] ConsoleSink's string representation
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/18539 I think that `ConsoleSink` was the only one with this mysterious name. We could however have another JIRA to _somehow_ unify how options are printed out for sources and sinks. I don't think it should be a part of this (smallish) change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18539: [SPARK-21313][SS] ConsoleSink's string representation
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18539 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18539: [SPARK-21313][SS] ConsoleSink's string representation
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18539 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79208/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18539: [SPARK-21313][SS] ConsoleSink's string representation
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18539 **[Test build #79208 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79208/testReport)** for PR 18539 at commit [`39a132f`](https://github.com/apache/spark/commit/39a132f58092b81675bf271977cb13ba6b5dc428). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18539: [SPARK-21313][SS] ConsoleSink's string representation
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18539 Seems OK, are there other sinks that could use a more useful toString? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18539: [SPARK-21313][SS] ConsoleSink's string representation
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18539 **[Test build #79208 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79208/testReport)** for PR 18539 at commit [`39a132f`](https://github.com/apache/spark/commit/39a132f58092b81675bf271977cb13ba6b5dc428). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
