[GitHub] spark issue #18929: [MINOR][LAUNCHER]remove never used String in SparkLaunch...
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/18929 My only concern is that some external projects which rely on this static variables will be broken because of this change, since they're public available, we cannot stop users to rely on them (though they can also change the codes). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18929: [MINOR][LAUNCHER]remove never used String in SparkLaunch...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18929 OK, I'd either use these constants where they can be used within the launcher module, or remove them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18929: [MINOR][LAUNCHER]remove never used String in SparkLaunch...
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/18929 @srowen In fact, we can replace spark.executor.memory with _SparkLauncher.EXECUTOR_MEMORY_ and replace spark.executor.cores with _SparkLauncher.EXECUTOR_CORES_. But in the process of modification, it also interrupts the consistency of other codes. So I chose to remove it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18929: [MINOR][LAUNCHER]remove never used String in SparkLaunch...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18929 These do look removable, but I don't think we should bother with PRs to remove things like this one or two at a time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18929: [MINOR][LAUNCHER]remove never used String in SparkLaunch...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18929 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
