[GitHub] spark issue #18983: [SPARK-21771][SQL]remove useless hive client in SparkSQL...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18983 Thanks! Merged to master/2.3 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18983: [SPARK-21771][SQL]remove useless hive client in SparkSQL...
Github user liufengdb commented on the issue: https://github.com/apache/spark/pull/18983 LGTM! It is only created once though. Frankly, we should completely remove the implementation of `newSession()` method. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18983: [SPARK-21771][SQL]remove useless hive client in SparkSQL...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18983 cc @liufengdb --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18983: [SPARK-21771][SQL]remove useless hive client in SparkSQL...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18983 LGTM, although I'm not very familiar with the thrift server code... --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18983: [SPARK-21771][SQL]remove useless hive client in SparkSQL...
Github user yaooqinn commented on the issue: https://github.com/apache/spark/pull/18983 besides, redirecting output here only is needed when there is an instance of a CliSessionState, otherwise, it will be done during the SessionState initializing in HiveClientImpl --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18983: [SPARK-21771][SQL]remove useless hive client in SparkSQL...
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/18983 Seems it should be okay to remove all the `metadataHive` things here. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18983: [SPARK-21771][SQL]remove useless hive client in SparkSQL...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18983 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86361/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18983: [SPARK-21771][SQL]remove useless hive client in SparkSQL...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18983 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18983: [SPARK-21771][SQL]remove useless hive client in SparkSQL...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18983 **[Test build #86361 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86361/testReport)** for PR 18983 at commit [`62611cd`](https://github.com/apache/spark/commit/62611cd024351ad9533f57fd422c447704df3028). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18983: [SPARK-21771][SQL]remove useless hive client in SparkSQL...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18983 **[Test build #86361 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86361/testReport)** for PR 18983 at commit [`62611cd`](https://github.com/apache/spark/commit/62611cd024351ad9533f57fd422c447704df3028). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18983: [SPARK-21771][SQL]remove useless hive client in SparkSQL...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18983 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18983: [SPARK-21771][SQL]remove useless hive client in SparkSQL...
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/18983 @hvanhovell Is there any specific reason that we still need to create a new `metadataHive` and redirect its output in `SparkSQLEnv.init()` ? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18983: [SPARK-21771][SQL]remove useless hive client in SparkSQL...
Github user yaooqinn commented on the issue: https://github.com/apache/spark/pull/18983 cc @hvanhovell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18983: [SPARK-21771][SQL]remove useless hive client in SparkSQL...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18983 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
