[GitHub] spark issue #19734: [SPARK-22442][SQL][BRANCH-2.2] ScalaReflection should pr...

2017-11-12 Thread viirya
Github user viirya commented on the issue:

https://github.com/apache/spark/pull/19734
  
`val TermName: TermNameExtractor` is new in scala 2.11. For 2.10, we should 
use deprecated `newTermName`. I will submit a follow-up.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19734: [SPARK-22442][SQL][BRANCH-2.2] ScalaReflection should pr...

2017-11-12 Thread viirya
Github user viirya commented on the issue:

https://github.com/apache/spark/pull/19734
  
@felixcheung Yes. Looking into it.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19734: [SPARK-22442][SQL][BRANCH-2.2] ScalaReflection should pr...

2017-11-12 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/spark/pull/19734
  
@viirya could you take a look 
https://amplab.cs.berkeley.edu/jenkins/job/spark-branch-2.2-compile-sbt-scala-2.10/724/



---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19734: [SPARK-22442][SQL][BRANCH-2.2] ScalaReflection should pr...

2017-11-12 Thread viirya
Github user viirya commented on the issue:

https://github.com/apache/spark/pull/19734
  
Thanks @felixcheung 


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19734: [SPARK-22442][SQL][BRANCH-2.2] ScalaReflection should pr...

2017-11-12 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/spark/pull/19734
  
merged to 2.2


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19734: [SPARK-22442][SQL][BRANCH-2.2] ScalaReflection should pr...

2017-11-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19734
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19734: [SPARK-22442][SQL][BRANCH-2.2] ScalaReflection should pr...

2017-11-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19734
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83763/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19734: [SPARK-22442][SQL][BRANCH-2.2] ScalaReflection should pr...

2017-11-12 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/spark/pull/19734
  
ok thanks, I'm above to tag 2.2.1. technically this isn't a regression but 
I could wait for a few hours (need to wait for jenkins build from the branch) 
if we could merge this ASAP


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19734: [SPARK-22442][SQL][BRANCH-2.2] ScalaReflection should pr...

2017-11-12 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/19734
  
**[Test build #83763 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83763/testReport)**
 for PR 19734 at commit 
[`8d3fd95`](https://github.com/apache/spark/commit/8d3fd950ca76d791335b9000133d0b1f897d2f87).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19734: [SPARK-22442][SQL][BRANCH-2.2] ScalaReflection should pr...

2017-11-12 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/19734
  
**[Test build #83763 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83763/testReport)**
 for PR 19734 at commit 
[`8d3fd95`](https://github.com/apache/spark/commit/8d3fd950ca76d791335b9000133d0b1f897d2f87).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19734: [SPARK-22442][SQL][BRANCH-2.2] ScalaReflection should pr...

2017-11-12 Thread viirya
Github user viirya commented on the issue:

https://github.com/apache/spark/pull/19734
  
cc @cloud-fan The backport of SPARK-22442 to branch 2.2.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org