[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user skambha commented on the issue: https://github.com/apache/spark/pull/19747 great! Thank you @gatorsmile, @hvanhovell, @wzhfy --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/19747 LGTM - merging to master. Thanks for working on this! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19747 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84271/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19747 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19747 **[Test build #84271 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84271/testReport)** for PR 19747 at commit [`d2458d4`](https://github.com/apache/spark/commit/d2458d478662e6d2d5fb31ce1c9ae48f8ccdaa33). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19747 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user skambha commented on the issue: https://github.com/apache/spark/pull/19747 Thanks @gatorsmile. I have addressed your comments in the latest commit. Please take a look. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19747 **[Test build #84271 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84271/testReport)** for PR 19747 at commit [`d2458d4`](https://github.com/apache/spark/commit/d2458d478662e6d2d5fb31ce1c9ae48f8ccdaa33). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19747 LGTM except a few minor comments. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19747 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84238/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19747 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19747 **[Test build #84238 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84238/testReport)** for PR 19747 at commit [`a1c8a6d`](https://github.com/apache/spark/commit/a1c8a6d308b62f3439f07dbf3257b51855cb09d8). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user skambha commented on the issue: https://github.com/apache/spark/pull/19747 Thanks @gatorsmile for your comments. I have incorporated them in the latest commit: https://github.com/apache/spark/pull/19747/commits/a1c8a6d308b62f3439f07dbf3257b51855cb09d8 Please take a look. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19747 **[Test build #84238 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84238/testReport)** for PR 19747 at commit [`a1c8a6d`](https://github.com/apache/spark/commit/a1c8a6d308b62f3439f07dbf3257b51855cb09d8). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19747 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83969/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19747 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19747 **[Test build #83969 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83969/testReport)** for PR 19747 at commit [`3be7b47`](https://github.com/apache/spark/commit/3be7b4736c93c6171677f6488c5a623c2eb38ad9). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19747 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19747 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83968/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19747 **[Test build #83968 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83968/testReport)** for PR 19747 at commit [`e5c2cf3`](https://github.com/apache/spark/commit/e5c2cf369912583b273ed573e3be4fdc5b9fb78d). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19747 **[Test build #83969 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83969/testReport)** for PR 19747 at commit [`3be7b47`](https://github.com/apache/spark/commit/3be7b4736c93c6171677f6488c5a623c2eb38ad9). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user skambha commented on the issue: https://github.com/apache/spark/pull/19747 I have taken care of adding the check in the new HiveClientImpl.alterTableDataSchema as well and have added some new tests. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19747 **[Test build #83968 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83968/testReport)** for PR 19747 at commit [`e5c2cf3`](https://github.com/apache/spark/commit/e5c2cf369912583b273ed573e3be4fdc5b9fb78d). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19747 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83888/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19747 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19747 **[Test build #83888 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83888/testReport)** for PR 19747 at commit [`cdc4a07`](https://github.com/apache/spark/commit/cdc4a0746fd86a8f19617c2cf042d9447014b473). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user skambha commented on the issue: https://github.com/apache/spark/pull/19747 I synced up and noticed there are some recent changes that have gone in that changes the alter table schema codepath in the HiveExternalCatalog. I'll take a look and see what changes might be needed for that. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user skambha commented on the issue: https://github.com/apache/spark/pull/19747 Thanks @wzhfy for your comments. I have addressed them in the latest commit. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19747 **[Test build #83888 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83888/testReport)** for PR 19747 at commit [`cdc4a07`](https://github.com/apache/spark/commit/cdc4a0746fd86a8f19617c2cf042d9447014b473). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19747 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19747 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83879/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19747 **[Test build #83879 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83879/testReport)** for PR 19747 at commit [`6267033`](https://github.com/apache/spark/commit/626703310aa269a9351a2cf7b6ce23f8e4ab095a). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19747 **[Test build #83879 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83879/testReport)** for PR 19747 at commit [`6267033`](https://github.com/apache/spark/commit/626703310aa269a9351a2cf7b6ce23f8e4ab095a). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19747 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/19747 Ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19747 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
