[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/19843 LGTM, but I'll wait for the PR title & description updates to merge this. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/19843 Also, can you please remove "WIP" from the PR title and update the Testing part of the PR description? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19843 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19843 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84637/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19843 **[Test build #84637 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84637/testReport)** for PR 19843 at commit [`9629b31`](https://github.com/apache/spark/commit/9629b31e577a40f71d660d22f48b0b59489a3471). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19843 **[Test build #84637 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84637/testReport)** for PR 19843 at commit [`9629b31`](https://github.com/apache/spark/commit/9629b31e577a40f71d660d22f48b0b59489a3471). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/19843 I'll make a call: Given that the SQL tests do not use clearActive, let's not bother with it. If we see flakiness, then we can try adding clearActive as a fix. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19843 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84600/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19843 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19843 **[Test build #84600 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84600/testReport)** for PR 19843 at commit [`8318611`](https://github.com/apache/spark/commit/831861124ba88aecdc649121832418c5dc6971a0). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class MLTestSuite extends MLTest ` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19843 **[Test build #84600 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84600/testReport)** for PR 19843 at commit [`8318611`](https://github.com/apache/spark/commit/831861124ba88aecdc649121832418c5dc6971a0). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/19843 add UT for MLTest and change to use PipelineModel. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/19843 This looks awesome; I just had a couple of comments. Btw, this is fancy test code. It might be nice to add a little unit test to MLTest.scala to make sure that testTransformer does indeed fail when the per-row check fails. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19843 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84328/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19843 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19843 **[Test build #84328 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84328/testReport)** for PR 19843 at commit [`ea19849`](https://github.com/apache/spark/commit/ea198494b5b5bf0ff658978e7aca193b4118b764). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * ` case class CheckAnswerRows(expectedAnswer: Seq[Row], lastOnly: Boolean, isSorted: Boolean)` * ` case class CheckAnswerRowsByFunc(checkFunction: Row => Unit, lastOnly: Boolean)` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19843 **[Test build #84328 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84328/testReport)** for PR 19843 at commit [`ea19849`](https://github.com/apache/spark/commit/ea198494b5b5bf0ff658978e7aca193b4118b764). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/19843 @MrBago Thanks! I update code, now new action class `CheckAnswerRowsByFunc` is added. I do not add common trait as both of them are simple and I don't want to break old code. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19843 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19843 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84290/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19843 **[Test build #84290 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84290/testReport)** for PR 19843 at commit [`08954fe`](https://github.com/apache/spark/commit/08954fe0e299a3dcf992d5a6cbd5f12d907ac453). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/19843 @MrBago @jkbradley --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19843 **[Test build #84290 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84290/testReport)** for PR 19843 at commit [`08954fe`](https://github.com/apache/spark/commit/08954fe0e299a3dcf992d5a6cbd5f12d907ac453). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/19843 Jenkins retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19843 **[Test build #84286 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84286/testReport)** for PR 19843 at commit [`072f4b9`](https://github.com/apache/spark/commit/072f4b9f330af61e7de07c8c2e57421448aa306b). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class LinearRegressionSuite extends MLTest with DefaultReadWriteTest ` * `trait MLTest extends StreamTest with TempDirectory ` * `trait TransformerStreamTest extends StreamTest ` * ` case class CheckAnswerRows(expectedAnswer: Seq[Row], lastOnly: Boolean, isSorted: Boolean,` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19843 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19843 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84286/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19843 **[Test build #84287 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84287/testReport)** for PR 19843 at commit [`08954fe`](https://github.com/apache/spark/commit/08954fe0e299a3dcf992d5a6cbd5f12d907ac453). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19843 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84287/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19843 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19843 **[Test build #84287 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84287/testReport)** for PR 19843 at commit [`08954fe`](https://github.com/apache/spark/commit/08954fe0e299a3dcf992d5a6cbd5f12d907ac453). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19843 **[Test build #84286 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84286/testReport)** for PR 19843 at commit [`072f4b9`](https://github.com/apache/spark/commit/072f4b9f330af61e7de07c8c2e57421448aa306b). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
