[GitHub] spark issue #19846: [SPARK-22393][SPARK-SHELL] spark-shell can't find import...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19846 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19846: [SPARK-22393][SPARK-SHELL] spark-shell can't find import...
Github user mpetruska commented on the issue: https://github.com/apache/spark/pull/19846 @HyukjinKwon : Hi, yes: this is the "retrofitting" of the original bug fix, which never made it to Scala 2.11. Instead of copy-pasting the original discussion, let me link the [original PR](https://github.com/scala/scala/pull/5640). I can add more details about specific parts, of course. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19846: [SPARK-22393][SPARK-SHELL] spark-shell can't find import...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19846 @mpetruska, btw can you fill up the PR description about how it fixes? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19846: [SPARK-22393][SPARK-SHELL] spark-shell can't find import...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19846 **[Test build #3998 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3998/testReport)** for PR 19846 at commit [`336446c`](https://github.com/apache/spark/commit/336446cb96d6d5985ec49d2c4643fae60d4c7007). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19846: [SPARK-22393][SPARK-SHELL] spark-shell can't find import...
Github user mpetruska commented on the issue: https://github.com/apache/spark/pull/19846 @srowen Yes, exactly. Tried to minimize the risks of any problems caused by this change. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19846: [SPARK-22393][SPARK-SHELL] spark-shell can't find import...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19846 **[Test build #3998 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3998/testReport)** for PR 19846 at commit [`336446c`](https://github.com/apache/spark/commit/336446cb96d6d5985ec49d2c4643fae60d4c7007). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19846: [SPARK-22393][SPARK-SHELL] spark-shell can't find import...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19846 OK, so this just affects the Scala 2.11 REPL in Spark (good, because the 2.12 version works a little differently and the fix is already in 2.12), and you've just copied in the fixed classes and injected the fixed impl? sounds reasonable. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19846: [SPARK-22393][SPARK-SHELL] spark-shell can't find import...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19846 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19846: [SPARK-22393][SPARK-SHELL] spark-shell can't find import...
Github user mpetruska commented on the issue: https://github.com/apache/spark/pull/19846 Sorry, could not refactor the code better; since it makes heavy use of path-dependent types. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
