[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...
Github user skambha commented on the issue: https://github.com/apache/spark/pull/19902 Opened a new PR to add the getDouble method. https://github.com/apache/spark/pull/19921 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...
Github user skambha commented on the issue: https://github.com/apache/spark/pull/19902 cool! I will add that and submit a new PR. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19902 ah i see, yea looks like `getByte`, `getShort` won't be very useful, let's add `getDouble` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...
Github user skambha commented on the issue: https://github.com/apache/spark/pull/19902 great! Thanks @gatorsmile , @cloud-fan. Yes. I would be happy to open a new PR to add the rest of them. If I compare with the getXXX types in SparkConf, it looks like the only missing one is to add getDouble. Do we want to add only that or any of the other datatypes or any other getXXX? Let me know and I would be happy to open a new PR to address it. Thank you! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19902 thanks, merging to master! @skambha would you like to open a new PR to add the rest of `getXXX` methods? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19902 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19902 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84582/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19902 **[Test build #84582 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84582/testReport)** for PR 19902 at commit [`7d87edc`](https://github.com/apache/spark/commit/7d87ed0573554b6b43e0cac17994652397bb). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19902 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84579/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19902 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19902 **[Test build #84579 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84579/testReport)** for PR 19902 at commit [`5de7962`](https://github.com/apache/spark/commit/5de7962755f2175d6d11dec262644e8b9afae08b). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19902 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19902 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84578/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19902 **[Test build #84578 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84578/testReport)** for PR 19902 at commit [`15e8ce5`](https://github.com/apache/spark/commit/15e8ce584180d014f8b1ffeb8f0e251299cb8f31). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19902 **[Test build #84582 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84582/testReport)** for PR 19902 at commit [`7d87edc`](https://github.com/apache/spark/commit/7d87ed0573554b6b43e0cac17994652397bb). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...
Github user skambha commented on the issue: https://github.com/apache/spark/pull/19902 great! Thanks @gatorsmile for your comments. I have updated with code comments, please take a look. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19902 LGTM except three comments. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19902 **[Test build #84579 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84579/testReport)** for PR 19902 at commit [`5de7962`](https://github.com/apache/spark/commit/5de7962755f2175d6d11dec262644e8b9afae08b). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19902 **[Test build #84578 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84578/testReport)** for PR 19902 at commit [`15e8ce5`](https://github.com/apache/spark/commit/15e8ce584180d014f8b1ffeb8f0e251299cb8f31). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19902 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84514/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19902 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19902 **[Test build #84514 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84514/testReport)** for PR 19902 at commit [`bb01ff5`](https://github.com/apache/spark/commit/bb01ff5ad214356a6bfdbebc36f1a7b2f37a46f1). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19902 **[Test build #84514 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84514/testReport)** for PR 19902 at commit [`bb01ff5`](https://github.com/apache/spark/commit/bb01ff5ad214356a6bfdbebc36f1a7b2f37a46f1). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19902 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19902 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
