[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19912 Thanks! Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19912 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84605/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19912 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19912 **[Test build #84605 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84605/testReport)** for PR 19912 at commit [`433587a`](https://github.com/apache/spark/commit/433587a55aecf78623f99f6d624449f0fe729853). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19912 **[Test build #84605 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84605/testReport)** for PR 19912 at commit [`433587a`](https://github.com/apache/spark/commit/433587a55aecf78623f99f6d624449f0fe729853). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19912 LGTM except 2 minor style comments --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19912 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19912 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19912 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84598/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19912 **[Test build #84598 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84598/testReport)** for PR 19912 at commit [`88cd025`](https://github.com/apache/spark/commit/88cd0253465a1c2f8d697b7eaaecd3d756a06e29). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19912 **[Test build #84598 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84598/testReport)** for PR 19912 at commit [`88cd025`](https://github.com/apache/spark/commit/88cd0253465a1c2f8d697b7eaaecd3d756a06e29). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19912 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19912 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19912 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84596/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19912 **[Test build #84596 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84596/testReport)** for PR 19912 at commit [`88cd025`](https://github.com/apache/spark/commit/88cd0253465a1c2f8d697b7eaaecd3d756a06e29). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19912 **[Test build #84596 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84596/testReport)** for PR 19912 at commit [`88cd025`](https://github.com/apache/spark/commit/88cd0253465a1c2f8d697b7eaaecd3d756a06e29). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/19912 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19912 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19912 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84593/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19912 **[Test build #84593 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84593/testReport)** for PR 19912 at commit [`88cd025`](https://github.com/apache/spark/commit/88cd0253465a1c2f8d697b7eaaecd3d756a06e29). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19912 **[Test build #84593 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84593/testReport)** for PR 19912 at commit [`88cd025`](https://github.com/apache/spark/commit/88cd0253465a1c2f8d697b7eaaecd3d756a06e29). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/19912 @gatorsmile @viirya thanks for reviewing! I have addressed your comments. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19912 New algorithm looks correct and good. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19912 Overall, it looks good to me. cc @jiangxb1987 @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19912 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84566/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19912 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19912 **[Test build #84566 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84566/testReport)** for PR 19912 at commit [`962faab`](https://github.com/apache/spark/commit/962faabb84a6b29af6d0ccb70afedcaecfdf4adc). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19912 **[Test build #84566 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84566/testReport)** for PR 19912 at commit [`962faab`](https://github.com/apache/spark/commit/962faabb84a6b29af6d0ccb70afedcaecfdf4adc). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
