[GitHub] spark issue #19949: [SPARK-22762][TEST] Basic tests for IfCoercion and CaseW...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19949 Thanks! Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19949: [SPARK-22762][TEST] Basic tests for IfCoercion and CaseW...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19949 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84948/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19949: [SPARK-22762][TEST] Basic tests for IfCoercion and CaseW...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19949 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19949: [SPARK-22762][TEST] Basic tests for IfCoercion and CaseW...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19949 **[Test build #84948 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84948/testReport)** for PR 19949 at commit [`8d04720`](https://github.com/apache/spark/commit/8d0472034e9267f7a6758b2ee9527f226e8f823e). * This patch **fails SparkR unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19949: [SPARK-22762][TEST] Basic tests for IfCoercion and CaseW...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19949 **[Test build #84948 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84948/testReport)** for PR 19949 at commit [`8d04720`](https://github.com/apache/spark/commit/8d0472034e9267f7a6758b2ee9527f226e8f823e). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19949: [SPARK-22762][TEST] Basic tests for IfCoercion and CaseW...
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/19949 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19949: [SPARK-22762][TEST] Basic tests for IfCoercion and CaseW...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19949 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84942/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19949: [SPARK-22762][TEST] Basic tests for IfCoercion and CaseW...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19949 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19949: [SPARK-22762][TEST] Basic tests for IfCoercion and CaseW...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19949 **[Test build #84942 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84942/testReport)** for PR 19949 at commit [`8d04720`](https://github.com/apache/spark/commit/8d0472034e9267f7a6758b2ee9527f226e8f823e). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19949: [SPARK-22762][TEST] Basic tests for IfCoercion and CaseW...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19949 **[Test build #84942 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84942/testReport)** for PR 19949 at commit [`8d04720`](https://github.com/apache/spark/commit/8d0472034e9267f7a6758b2ee9527f226e8f823e). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19949: [SPARK-22762][TEST] Basic tests for IfCoercion and CaseW...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19949 LGTM except the comment about `short` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19949: [SPARK-22762][TEST] Basic tests for IfCoercion and CaseW...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19949 Ah, I just checked the log and seems quite short. I take my words back. I am fine. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19949: [SPARK-22762][TEST] Basic tests for IfCoercion and CaseW...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19949 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19949: [SPARK-22762][TEST] Basic tests for IfCoercion and CaseW...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19949 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84757/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19949: [SPARK-22762][TEST] Basic tests for IfCoercion and CaseW...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19949 **[Test build #84757 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84757/testReport)** for PR 19949 at commit [`f9da910`](https://github.com/apache/spark/commit/f9da9103eacdad8a7d544e9d17b8a54d6b7e01c5). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19949: [SPARK-22762][TEST] Basic tests for IfCoercion and CaseW...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19949 To be clear, I am not against this change. I am asking this because simply I remember I was working on another stuff related with tests but the elapsed time concern was raised before. I see a bunch of tests being added here and I think it's a valid concern. I simply just wonder the elapsed time (wouldn't be difficult to check) and how many tests are supposed to be added. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19949: [SPARK-22762][TEST] Basic tests for IfCoercion and CaseW...
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/19949 @HyukjinKwon see: https://issues.apache.org/jira/browse/SPARK-22722 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19949: [SPARK-22762][TEST] Basic tests for IfCoercion and CaseW...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19949 **[Test build #84757 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84757/testReport)** for PR 19949 at commit [`f9da910`](https://github.com/apache/spark/commit/f9da9103eacdad8a7d544e9d17b8a54d6b7e01c5). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19949: [SPARK-22762][TEST] Basic tests for IfCoercion and CaseW...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19949 Out of curiosity, does anyone know if we are okay with elapsed time now? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
