[GitHub] spark issue #20088: [SPARK-22905][ML][MLLIB][CORE] Fix ChiSqSelectorModel sa...
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/20088 This is hopefully a rare case of an error in assuming an ordering of rows; in general, we shouldn't (and don't, AFAIK) assume an order for rows in saving/loading models. LGTM, but before this is merged, can you please remove the ML and CORE tags from the PR title @WeichenXu123 ? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20088: [SPARK-22905][ML][MLLIB][CORE] Fix ChiSqSelectorModel sa...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20088 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85422/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20088: [SPARK-22905][ML][MLLIB][CORE] Fix ChiSqSelectorModel sa...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20088 **[Test build #85422 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85422/testReport)** for PR 20088 at commit [`5fd56c3`](https://github.com/apache/spark/commit/5fd56c350cb410740209fba32c19489847a1d019). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20088: [SPARK-22905][ML][MLLIB][CORE] Fix ChiSqSelectorModel sa...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20088 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20088: [SPARK-22905][ML][MLLIB][CORE] Fix ChiSqSelectorModel sa...
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/20088 Currently I cannot construct a failed test for this issue, but the future PR (changing `RoundRobinPartitioning`) by @jiangxb1987 will trigger this bug. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20088: [SPARK-22905][ML][MLLIB][CORE] Fix ChiSqSelectorModel sa...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20088 **[Test build #85422 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85422/testReport)** for PR 20088 at commit [`5fd56c3`](https://github.com/apache/spark/commit/5fd56c350cb410740209fba32c19489847a1d019). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
