[GitHub] spark issue #20176: [SPARK-22981][SQL] Fix incorrect results of Casting Stru...
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20176 ok, I'll make a follow-up for `showString` later. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20176: [SPARK-22981][SQL] Fix incorrect results of Casting Stru...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20176 show binary as string and cast binary to string seems different to me, let's stick with what it is. BTW it's pretty dangerous to change the behavior of cast to be different with Hive. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20176: [SPARK-22981][SQL] Fix incorrect results of Casting Stru...
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20176
hive one is the same with mysql one;
```
hive> create table t(a BINARY);
OK
hive> INSERT INTO t values('abc');
OK
hive> select CAST(a AS STRING) from t;
OK
abc
```
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20176: [SPARK-22981][SQL] Fix incorrect results of Casting Stru...
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20176
Thanks! Next, I'll fix `showString` though, one question; currently casting
binary to string is different between
[Cast](https://github.com/apache/spark/blob/2250cb75b99d257e698fe5418a51d8cddb4d5104/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala#L205)
and
[showString](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala#L254).
Which one is expected?
FYI: This casting behaviour is different between mysql and postgresql;
```
postgres=# create table t (a bytea);
CREATE TABLE
postgres=# insert into t values('abc');
INSERT 0 1
postgres=# SELECT CAST(a AS TEXT) from t;
a
--
\x616263
mysql> create table t(a blob);
Query OK, 0 rows affected (0.02 sec)
mysql> insert into t values('abc');
Query OK, 1 row affected (0.00 sec)
mysql> select CAST(a AS char) From t;
+-+
| CAST(a AS char) |
+-+
| abc |
+-+
1 row in set (0.00 sec)
```
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20176: [SPARK-22981][SQL] Fix incorrect results of Casting Stru...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20176 LGTM, merging to master/2.3! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20176: [SPARK-22981][SQL] Fix incorrect results of Casting Stru...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20176 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85844/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20176: [SPARK-22981][SQL] Fix incorrect results of Casting Stru...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20176 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20176: [SPARK-22981][SQL] Fix incorrect results of Casting Stru...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20176 **[Test build #85844 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85844/testReport)** for PR 20176 at commit [`6f5b080`](https://github.com/apache/spark/commit/6f5b0803fb65b1cc88b0dc2e09d2e9efd76a1368). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20176: [SPARK-22981][SQL] Fix incorrect results of Casting Stru...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20176 **[Test build #85844 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85844/testReport)** for PR 20176 at commit [`6f5b080`](https://github.com/apache/spark/commit/6f5b0803fb65b1cc88b0dc2e09d2e9efd76a1368). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20176: [SPARK-22981][SQL] Fix incorrect results of Casting Stru...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20176 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20176: [SPARK-22981][SQL] Fix incorrect results of Casting Stru...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20176 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85838/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20176: [SPARK-22981][SQL] Fix incorrect results of Casting Stru...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20176 **[Test build #85838 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85838/testReport)** for PR 20176 at commit [`6f5b080`](https://github.com/apache/spark/commit/6f5b0803fb65b1cc88b0dc2e09d2e9efd76a1368). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20176: [SPARK-22981][SQL] Fix incorrect results of Casting Stru...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20176 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20176: [SPARK-22981][SQL] Fix incorrect results of Casting Stru...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20176 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20176: [SPARK-22981][SQL] Fix incorrect results of Casting Stru...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20176 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85834/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20176: [SPARK-22981][SQL] Fix incorrect results of Casting Stru...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20176 **[Test build #85834 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85834/testReport)** for PR 20176 at commit [`3dcbcc2`](https://github.com/apache/spark/commit/3dcbcc2e32caa1120cd4aac4cc8ec03c831de12c). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20176: [SPARK-22981][SQL] Fix incorrect results of Casting Stru...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20176 **[Test build #85838 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85838/testReport)** for PR 20176 at commit [`6f5b080`](https://github.com/apache/spark/commit/6f5b0803fb65b1cc88b0dc2e09d2e9efd76a1368). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20176: [SPARK-22981][SQL] Fix incorrect results of Casting Stru...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20176 **[Test build #85834 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85834/testReport)** for PR 20176 at commit [`3dcbcc2`](https://github.com/apache/spark/commit/3dcbcc2e32caa1120cd4aac4cc8ec03c831de12c). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20176: [SPARK-22981][SQL] Fix incorrect results of Casting Stru...
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20176 @cloud-fan ping --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20176: [SPARK-22981][SQL] Fix incorrect results of Casting Stru...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20176 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85770/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20176: [SPARK-22981][SQL] Fix incorrect results of Casting Stru...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20176 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20176: [SPARK-22981][SQL] Fix incorrect results of Casting Stru...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20176 **[Test build #85770 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85770/testReport)** for PR 20176 at commit [`10285d0`](https://github.com/apache/spark/commit/10285d0ee8ba037809a9d15409a5c5055cd5be84). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20176: [SPARK-22981][SQL] Fix incorrect results of Casting Stru...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20176 **[Test build #85770 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85770/testReport)** for PR 20176 at commit [`10285d0`](https://github.com/apache/spark/commit/10285d0ee8ba037809a9d15409a5c5055cd5be84). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20176: [SPARK-22981][SQL] Fix incorrect results of Casting Stru...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20176 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20176: [SPARK-22981][SQL] Fix incorrect results of Casting Stru...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20176 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85767/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20176: [SPARK-22981][SQL] Fix incorrect results of Casting Stru...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20176 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20176: [SPARK-22981][SQL] Fix incorrect results of Casting Stru...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20176 **[Test build #85767 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85767/testReport)** for PR 20176 at commit [`10285d0`](https://github.com/apache/spark/commit/10285d0ee8ba037809a9d15409a5c5055cd5be84). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20176: [SPARK-22981][SQL] Fix incorrect results of Casting Stru...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20176 **[Test build #85767 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85767/testReport)** for PR 20176 at commit [`10285d0`](https://github.com/apache/spark/commit/10285d0ee8ba037809a9d15409a5c5055cd5be84). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
