[GitHub] spark issue #20223: [SPARK-23020][core] Fix races in launcher code, test.
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20223 At this point in time it might be a good idea to revert SPARK-10300, since the YARN tests don't really add that much to the test run time compared to the others anymore... --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20223: [SPARK-23020][core] Fix races in launcher code, test.
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20223 We didn't run the yarn test with this PR due to https://issues.apache.org/jira/browse/SPARK-10300 This indicates that it might be a bad idea to skip the yarn test if we don't change yarn code. In this case, we touch the code in spark code and cause the failure in yarn test. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20223: [SPARK-23020][core] Fix races in launcher code, test.
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20223 This patch unfortunately broke [`YarnClusterSuite.timeout to get SparkContext in cluster mode triggers failure`](https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-branch-2.3-test-maven-hadoop-2.7/94/testReport/org.apache.spark.deploy.yarn/YarnClusterSuite/timeout_to_get_SparkContext_in_cluster_mode_triggers_failure/history/) and [`SparkLauncherSuite.testInProcessLauncher`](https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-branch-2.3-test-maven-hadoop-2.7/90/testReport/org.apache.spark.launcher/SparkLauncherSuite/testInProcessLauncher/history/) is still flaky. I'm going to revert this patch and temporarily disable the test in `SparkLauncherSuite` to fix the build. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20223: [SPARK-23020][core] Fix races in launcher code, test.
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20223 merging to master/2.3. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20223: [SPARK-23020][core] Fix races in launcher code, test.
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20223 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20223: [SPARK-23020][core] Fix races in launcher code, test.
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20223 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86142/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20223: [SPARK-23020][core] Fix races in launcher code, test.
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20223 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20223: [SPARK-23020][core] Fix races in launcher code, test.
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20223 **[Test build #86142 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86142/testReport)** for PR 20223 at commit [`8d52338`](https://github.com/apache/spark/commit/8d52338eed18bcc82ad04179e966f9eca064e68c). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20223: [SPARK-23020][core] Fix races in launcher code, test.
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20223 **[Test build #86142 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86142/testReport)** for PR 20223 at commit [`8d52338`](https://github.com/apache/spark/commit/8d52338eed18bcc82ad04179e966f9eca064e68c). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20223: [SPARK-23020][core] Fix races in launcher code, test.
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20223 Retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20223: [SPARK-23020][core] Fix races in launcher code, test.
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20223 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20223: [SPARK-23020][core] Fix races in launcher code, test.
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20223 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85986/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20223: [SPARK-23020][core] Fix races in launcher code, test.
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20223 **[Test build #85986 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85986/testReport)** for PR 20223 at commit [`8d52338`](https://github.com/apache/spark/commit/8d52338eed18bcc82ad04179e966f9eca064e68c). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20223: [SPARK-23020][core] Fix races in launcher code, test.
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20223 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20223: [SPARK-23020][core] Fix races in launcher code, test.
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20223 **[Test build #85984 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85984/testReport)** for PR 20223 at commit [`9c7d2d3`](https://github.com/apache/spark/commit/9c7d2d3ee1cb4d9ec36607dd69122c55daea4172). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20223: [SPARK-23020][core] Fix races in launcher code, test.
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20223 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85984/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20223: [SPARK-23020][core] Fix races in launcher code, test.
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20223 **[Test build #85986 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85986/testReport)** for PR 20223 at commit [`8d52338`](https://github.com/apache/spark/commit/8d52338eed18bcc82ad04179e966f9eca064e68c). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20223: [SPARK-23020][core] Fix races in launcher code, test.
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20223 **[Test build #85984 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85984/testReport)** for PR 20223 at commit [`9c7d2d3`](https://github.com/apache/spark/commit/9c7d2d3ee1cb4d9ec36607dd69122c55daea4172). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20223: [SPARK-23020][core] Fix races in launcher code, test.
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20223 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20223: [SPARK-23020][core] Fix races in launcher code, test.
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20223 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85937/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20223: [SPARK-23020][core] Fix races in launcher code, test.
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20223 **[Test build #85937 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85937/testReport)** for PR 20223 at commit [`2018e29`](https://github.com/apache/spark/commit/2018e295f516d51e8c1661d3b77c31a029fdb006). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20223: [SPARK-23020][core] Fix races in launcher code, test.
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20223 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20223: [SPARK-23020][core] Fix races in launcher code, test.
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20223 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85929/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20223: [SPARK-23020][core] Fix races in launcher code, test.
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20223 **[Test build #85929 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85929/testReport)** for PR 20223 at commit [`5139f60`](https://github.com/apache/spark/commit/5139f605904996667d8d97941172bbe9d366a579). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20223: [SPARK-23020][core] Fix races in launcher code, test.
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20223 **[Test build #85937 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85937/testReport)** for PR 20223 at commit [`2018e29`](https://github.com/apache/spark/commit/2018e295f516d51e8c1661d3b77c31a029fdb006). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20223: [SPARK-23020][core] Fix races in launcher code, test.
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20223 **[Test build #85929 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85929/testReport)** for PR 20223 at commit [`5139f60`](https://github.com/apache/spark/commit/5139f605904996667d8d97941172bbe9d366a579). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
